Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in services build.gradle resulting in directions refresh not being included in services artifact #966

Merged
merged 4 commits into from
Feb 13, 2019

Conversation

devotaaabel
Copy link
Contributor

No description provided.

@@ -39,7 +39,7 @@ public static Builder builder() {
* @since 4.4.0
*/
@Nullable
public abstract String routeIndex();
public abstract Integer routeIndex();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking SemVer and it seems out of scope of this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @devotaaabel 🚀

@devotaaabel devotaaabel merged commit 601c97c into master Feb 13, 2019
@devotaaabel devotaaabel deleted the devota-add-DR-to-services branch February 13, 2019 17:20
This was referenced Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants