Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code coverage report generation and upload to Codecov #925

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

langsmith
Copy link

cc @springmeyer

This pr adds the ability to generate code coverage reports and then upload those reports to our Codecov account.

Running ./gradlew jacocoTestReport was already possible on master, but that Gradle command didn't produce any code coverage reports. This pr implements https://github.com/vanniktech/gradle-android-junit-jacoco-plugin to successfully generate JaCoCo test reports 👇 . This Gradle plugin is the same one that easily creates reports in the China plugin repo.

screen shot 2018-11-27 at 4 25 08 pm

screen shot 2018-11-27 at 4 25 26 pm

screen shot 2018-11-27 at 4 26 08 pm

screen shot 2018-11-27 at 4 32 14 pm

@langsmith langsmith added the Test label Nov 28, 2018
@langsmith langsmith self-assigned this Nov 28, 2018
@langsmith langsmith requested a review from osana November 28, 2018 00:34
@langsmith langsmith merged commit 57f429f into master Nov 29, 2018
@langsmith langsmith deleted the ls-adding-codecov branch November 29, 2018 01:26
@Guardiola31337 Guardiola31337 mentioned this pull request Dec 1, 2018
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants