Adding explode turf method (#1007)

mapbox · May 2, 2019 · 86b0594 · 86b0594
1 parent 02ff671
commit 86b0594
Show file tree

Hide file tree

Showing 12 changed files with 386 additions and 1 deletion.
diff --git a/docs/turf-port.md b/docs/turf-port.md
@@ -59,7 +59,7 @@ Below's an on going list of the Turf functions which currently exist inside the
 
 ## Feature Conversion
 - [ ] turf-combine
-- [ ] turf-explode
+- [x] turf-explode
 - [ ] turf-flatten
 - [ ] turf-line-to-polygon
 - [ ] turf-polygonize

diff --git a/services-turf/src/main/java/com/mapbox/turf/TurfConversion.java b/services-turf/src/main/java/com/mapbox/turf/TurfConversion.java
@@ -3,9 +3,15 @@
 import android.support.annotation.FloatRange;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
+
+import com.mapbox.geojson.Feature;
+import com.mapbox.geojson.FeatureCollection;
+import com.mapbox.geojson.Point;
 import com.mapbox.turf.TurfConstants.TurfUnitCriteria;
 
+import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
 /**
@@ -163,4 +169,36 @@ public static double convertLength(@FloatRange(from = 0) double distance,
     }
     return radiansToLength(lengthToRadians(distance, originalUnit), finalUnit);
   }
+
+  /**
+   * Takes a {@link FeatureCollection} and
+   * returns all positions as {@link Point} objects.
+   *
+   * @param featureCollection a {@link FeatureCollection} object
+   * @return a new {@link FeatureCollection} object with {@link Point} objects
+   * @since 4.8.0
+   */
+  public static FeatureCollection explode(@NonNull FeatureCollection featureCollection) {
+    List<Feature> finalFeatureList = new ArrayList<>();
+    for (Point singlePoint : TurfMeta.coordAll(featureCollection, true)) {
+      finalFeatureList.add(Feature.fromGeometry(singlePoint));
+    }
+    return FeatureCollection.fromFeatures(finalFeatureList);
+  }
+
+  /**
+   * Takes a {@link Feature}  and
+   * returns its position as a {@link Point} objects.
+   *
+   * @param feature a {@link Feature} object
+   * @return a new {@link FeatureCollection} object with {@link Point} objects
+   * @since 4.8.0
+   */
+  public static FeatureCollection explode(@NonNull Feature feature) {
+    List<Feature> finalFeatureList = new ArrayList<>();
+    for (Point singlePoint : TurfMeta.coordAll(feature, true)) {
+      finalFeatureList.add(Feature.fromGeometry(singlePoint));
+    }
+    return FeatureCollection.fromFeatures(finalFeatureList);
+  }
 }
diff --git a/services-turf/src/test/java/com/mapbox/turf/TurfConversionTest.java b/services-turf/src/test/java/com/mapbox/turf/TurfConversionTest.java
@@ -1,13 +1,32 @@
 package com.mapbox.turf;
 
+import com.mapbox.geojson.Feature;
+import com.mapbox.geojson.FeatureCollection;
+import com.mapbox.geojson.GeometryCollection;
+import com.mapbox.geojson.LineString;
+import com.mapbox.geojson.MultiLineString;
+import com.mapbox.geojson.MultiPoint;
+import com.mapbox.geojson.MultiPolygon;
+import com.mapbox.geojson.Point;
+import com.mapbox.geojson.Polygon;
+
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
 
+import java.io.IOException;
+import java.util.Arrays;
+
 import static org.junit.Assert.assertEquals;
 
 public class TurfConversionTest extends TestUtils {
 
+  private static final String TURF_EXPLODE_MULTI_POINT = "turf-explode/multipoint.geojson";
+  private static final String TURF_EXPLODE_LINESTRING = "turf-explode/linestring.geojson";
+  private static final String TURF_EXPLODE_MULTILINESTRING = "turf-explode/multilinestring.geojson";
+  private static final String TURF_EXPLODE_MULTIPOLYGON = "turf-explode/multipolygon.geojson";
+  private static final String TURF_EXPLODE_GEOMETRY_COLLECTION = "turf-explode/geometrycollection.geojson";
+
   @Rule
   public ExpectedException thrown = ExpectedException.none();
 
@@ -58,4 +77,60 @@ public void convertDistance() throws TurfException {
       TurfConversion.convertLength(1, TurfConstants.UNIT_METERS,
         TurfConstants.UNIT_CENTIMETERS), DELTA);
   }
+
+  @Test
+  public void explodePointSingleFeature() throws IOException, NullPointerException {
+    Point point = Point.fromLngLat(102, 0.5);
+    assertEquals(1, TurfConversion.explode(Feature.fromGeometry(point)).features().size());
+  }
+
+  @Test
+  public void explodeMultiPointSingleFeature() throws IOException, NullPointerException {
+    MultiPoint multiPoint = MultiPoint.fromJson(loadJsonFixture(TURF_EXPLODE_MULTI_POINT));
+    assertEquals(4, TurfConversion.explode(Feature.fromGeometry(multiPoint)).features().size());
+  }
+
+  @Test
+  public void explodeLineStringSingleFeature() throws IOException, NullPointerException {
+    LineString lineString = LineString.fromJson(loadJsonFixture(TURF_EXPLODE_LINESTRING));
+    assertEquals(4, TurfConversion.explode(Feature.fromGeometry(lineString)).features().size());
+  }
+
+  @Test
+  public void explodePolygonSingleFeature() throws IOException, NullPointerException {
+    Polygon polygon = Polygon.fromLngLats(Arrays.asList(
+      Arrays.asList(
+        Point.fromLngLat(0, 101),
+        Point.fromLngLat(1, 101),
+        Point.fromLngLat(1, 100),
+        Point.fromLngLat(0, 100))));
+    assertEquals(3, TurfConversion.explode(Feature.fromGeometry(polygon)).features().size());
+  }
+
+  @Test
+  public void explodeMultiLineStringSingleFeature() throws IOException, NullPointerException {
+    MultiLineString multiLineString = MultiLineString.fromJson(loadJsonFixture(TURF_EXPLODE_MULTILINESTRING));
+    assertEquals(4, TurfConversion.explode(Feature.fromGeometry(multiLineString)).features().size());
+  }
+
+  @Test
+  public void explodeMultiPolygonSingleFeature() throws IOException, NullPointerException {
+    MultiPolygon multiPolygon = MultiPolygon.fromJson(loadJsonFixture(TURF_EXPLODE_MULTIPOLYGON));
+    assertEquals(12, TurfConversion.explode(Feature.fromGeometry(multiPolygon)).features().size());
+  }
+
+  @Test
+  public void explodeGeometryCollectionSingleFeature() throws IOException, NullPointerException {
+    GeometryCollection geometryCollection = GeometryCollection.fromJson(loadJsonFixture(TURF_EXPLODE_GEOMETRY_COLLECTION));
+    assertEquals(3, TurfConversion.explode(Feature.fromGeometry(geometryCollection)).features().size());
+  }
+
+  @Test
+  public void explodeFeatureCollection() throws IOException, NullPointerException {
+    FeatureCollection featureCollection = FeatureCollection.fromFeatures(new Feature[] {
+      Feature.fromGeometry(MultiLineString.fromJson(loadJsonFixture(TURF_EXPLODE_MULTILINESTRING))),
+      Feature.fromGeometry(MultiPolygon.fromJson(loadJsonFixture(TURF_EXPLODE_MULTIPOLYGON)))
+    });
+    assertEquals(16, TurfConversion.explode(featureCollection).features().size());
+  }
 }
diff --git a/services-turf/src/test/resources/turf-bbox/point.geojson b/services-turf/src/test/resources/turf-bbox/point.geojson
@@ -1,5 +1,6 @@
 {
   "type": "Feature",
+  "properties": {},
   "geometry": {
     "type": "Point",
     "coordinates": [

diff --git a/services-turf/src/test/resources/turf-explode/feature_collection.geojson b/services-turf/src/test/resources/turf-explode/feature_collection.geojson
@@ -0,0 +1,72 @@
+{
+  "type": "FeatureCollection",
+  "features": [
+    {
+      "type": "Feature",
+      "geometry": {
+        "type": "Point",
+        "coordinates": [
+          102,
+          0.5
+        ]
+      },
+      "properties": {}
+    },
+    {
+      "type": "Feature",
+      "geometry": {
+        "type": "LineString",
+        "coordinates": [
+          [
+            102,
+            -10
+          ],
+          [
+            103,
+            1
+          ],
+          [
+            104,
+            0
+          ],
+          [
+            130,
+            4
+          ]
+        ]
+      },
+      "properties": {}
+    },
+    {
+      "type": "Feature",
+      "geometry": {
+        "type": "Polygon",
+        "coordinates": [
+          [
+            [
+              20,
+              0
+            ],
+            [
+              101,
+              0
+            ],
+            [
+              101,
+              1
+            ],
+            [
+              100,
+              1
+            ],
+            [
+              100,
+              0
+            ]
+          ]
+        ]
+      },
+      "properties": {}
+    }
+  ]
+}
diff --git a/services-turf/src/test/resources/turf-explode/geometrycollection.geojson b/services-turf/src/test/resources/turf-explode/geometrycollection.geojson
@@ -0,0 +1,15 @@
+{
+   "type": "GeometryCollection",
+   "geometries": [
+       {
+           "type": "Point",
+           "coordinates": [100.0, 0.0]
+       },
+       {
+           "type": "LineString",
+           "coordinates": [
+               [101.0, 0.0], [102.0, 1.0]
+           ]
+       }
+   ]
+}
diff --git a/services-turf/src/test/resources/turf-explode/linestring.geojson b/services-turf/src/test/resources/turf-explode/linestring.geojson
@@ -0,0 +1,21 @@
+{
+  "type": "LineString",
+  "coordinates": [
+    [
+      102,
+      -10
+    ],
+    [
+      103,
+      1
+    ],
+    [
+      104,
+      0
+    ],
+    [
+      130,
+      4
+    ]
+  ]
+}
diff --git a/services-turf/src/test/resources/turf-explode/multilinestring.geojson b/services-turf/src/test/resources/turf-explode/multilinestring.geojson
@@ -0,0 +1,25 @@
+{
+  "type": "MultiLineString",
+  "coordinates": [
+    [
+      [
+        100,
+        0
+      ],
+      [
+        101,
+        1
+      ]
+    ],
+    [
+      [
+        102,
+        2
+      ],
+      [
+        103,
+        3
+      ]
+    ]
+  ]
+}
diff --git a/services-turf/src/test/resources/turf-explode/multipoint.geojson b/services-turf/src/test/resources/turf-explode/multipoint.geojson
@@ -0,0 +1,21 @@
+{
+  "type": "MultiPoint",
+  "coordinates": [
+    [
+      102,
+      -10
+    ],
+    [
+      103,
+      1
+    ],
+    [
+      104,
+      0
+    ],
+    [
+      130,
+      4
+    ]
+  ]
+}
diff --git a/services-turf/src/test/resources/turf-explode/multipolygon.geojson b/services-turf/src/test/resources/turf-explode/multipolygon.geojson
@@ -0,0 +1,75 @@
+{
+  "type": "MultiPolygon",
+  "coordinates": [
+    [
+      [
+        [
+          102,
+          2
+        ],
+        [
+          103,
+          2
+        ],
+        [
+          103,
+          3
+        ],
+        [
+          102,
+          3
+        ],
+        [
+          102,
+          2
+        ]
+      ]
+    ],
+    [
+      [
+        [
+          100,
+          0
+        ],
+        [
+          101,
+          0
+        ],
+        [
+          101,
+          1
+        ],
+        [
+          100,
+          1
+        ],
+        [
+          100,
+          0
+        ]
+      ],
+      [
+        [
+          100.2,
+          0.2
+        ],
+        [
+          100.8,
+          0.2
+        ],
+        [
+          100.8,
+          0.8
+        ],
+        [
+          100.2,
+          0.8
+        ],
+        [
+          100.2,
+          0.2
+        ]
+      ]
+    ]
+  ]
+}