This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Feature: Dynamically localize compass text #949
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draw the compass text dynamically based on the user's device language. This adds
CompassBlank.png
at the three necessary scales.I don't know what the localization plans are (and being pre-beta it's surely not a high priority), so this hardcodes the different localized strings rather than messing with anything more involved. Once localization gets on the roadmap this will have to be revisited.
Japanese/Chinese
English/Default
Apple Maps in Japanese
... not sure why I've been so fixated on compasses, but hopefully this is useful. I also tossed in
Compass@3x.png
for the hell of it.