Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] Updated maximumZoomLevel description, cherry-picked #8818 #8842

Merged
merged 4 commits into from
May 1, 2017
Merged

[ios, macos] Updated maximumZoomLevel description, cherry-picked #8818 #8842

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
917b7c9
[ios] swapped link for circle layer example
Apr 25, 2017
b6d0c9e
[ios, macos] maximum zoom level description
Apr 27, 2017
499329b
[ios, macos] made changes suggested by 1ec5
Apr 28, 2017
df70f55
[ios, macos] changed to clarify value is a floating-point number
Apr 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platform/darwin/src/MGLStyleLayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ MGL_EXPORT
@property (nonatomic, assign, getter=isVisible) BOOL visible;

/**
The maximum zoom level at which the layer gets parsed and appears.
The maximum zoom level that the layer gets parsed and appears up to (but not including).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multiple dangling prepositions are a bit awkward here. Also, I missed this before, but “parsing” a layer only makes sense in the context of style JSON, not runtime styling. How about:

The exclusive upper bound of the range of zoom levels within which a map would display the layer.

For consistency, the minimumZoomLevel description would become:

The inclusive lower bound of the range of zoom levels within which a map would display the layer.

*/
@property (nonatomic, assign) float maximumZoomLevel;

Expand Down
2 changes: 1 addition & 1 deletion platform/ios/docs/guides/Working with Mapbox Studio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ To implement your prototypes with runtime styling:

1. Implement `-[MGLMapViewDelegate mapView:didFinishLoadingStyle:]`.
2. Add your real data as a source:
* This can be done using vector data from tileset editor ([example](https://www.mapbox.com/ios-sdk/examples/runtime-circle-styles)), custom vector tiles, added as GeoJSON ([example](https://www.mapbox.com/ios-sdk/examples/runtime-add-line), or added manually through the app via `MGLShapeSource` ([example](https://www.mapbox.com/ios-sdk/examples/runtime-multiple-annotations))
* This can be done using vector data from tileset editor ([example](https://www.mapbox.com/ios-sdk/examples/dds-circle-layer)), custom vector tiles, added as GeoJSON ([example](https://www.mapbox.com/ios-sdk/examples/runtime-add-line), or added manually through the app via `MGLShapeSource` ([example](https://www.mapbox.com/ios-sdk/examples/runtime-multiple-annotations))
3. For each layer you’ve prototyped in Studio, add its corresponding `MGLStyleLayer` subclass. See [“Configuring the map content’s appearance”](for-style-authors.html#configuring-the-map-content-s-appearance) for the available style layer classes.

**Translating style attributes from Studio**
Expand Down