This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Add overlays property to MGLMapView.mm
#8617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eimantas
changed the title
overlays property to MGLMapView.mmoverlays property to MGLMapView.mm
1ec5
reviewed
May 12, 2017
platform/ios/src/MGLMapView.h
Outdated
| overlays are associated with the map view, the value of this property is | ||
| `nil`. | ||
| */ | ||
| @property (nonatomic, readonly, nullable) NS_ARRAY_OF(id <MGLOverlay>) *overlays; |
There was a problem hiding this comment.
As of iOS 9, MKMapView.annotations and MKMapView.overlays have changed to being non-nullable, returning an empty array when the map contains no annotation or no overlay. This would be a good opportunity to follow suit. (Since making the property non-nullable would also change it from optional to non-optional in Swift, we whould need to add a blurb to both changelogs about this change.)
platform/ios/src/MGLMapView.mm
Outdated
| { | ||
| if (self.annotations == nil) { return nil; } | ||
|
|
||
| NS_MUTABLE_ARRAY_OF(id <MGLOverlay>) *mutableOverlays = [NSMutableArray new]; |
There was a problem hiding this comment.
Nit: use +[NSMutableArray array] instead of +[NSMutableArray new]. In general, we avoid +new because it’s inconsistent with the normal init pattern.
|
Should I match [non]nullability to macOS SDK too? |
1ec5
approved these changes
May 12, 2017
1ec5
added
annotations
Implemented by filtering the `annotations` property for annotations that conform to `MGLOverlay` protocol.
Copied verbatim from `annotations` property. Changed types.
Implementation is identical to the one in macOS SDK.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented by filtering the
annotationsproperty forannotations that conform to
MGLOverlayprotocol.Fixes #4281.