Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Traditional Chinese localization #7899

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Traditional Chinese localization #7899

merged 1 commit into from
Feb 3, 2017

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jan 30, 2017

Added Traditional Chinese localizations to the iOS and macOS SDKs, using OpenCC to convert the Simplified Chinese localizations added in #7316 and #7503. (Instructions)

I spot-checked the results but would appreciate a review by @lily-chai, @virginiayung, or @jenyuhk. Also, if any of these strings could have more idiomatic translations, we could add Taiwan- or Hong Kong–specific localizations, again using OpenCC.

Fixes #7370.

/cc @YunjieLi @friedbunny

@1ec5 1ec5 added Google Maps parity For feature parity with the Google Maps SDK for Android or iOS iOS Mapbox Maps SDK for iOS localization Human language support and internationalization macOS Mapbox Maps SDK for macOS MapKit parity For feature parity with MapKit on iOS or macOS labels Jan 30, 2017
@1ec5 1ec5 added this to the ios-v3.5.0 milestone Jan 30, 2017
@1ec5 1ec5 self-assigned this Jan 30, 2017
@1ec5 1ec5 requested a review from YunjieLi January 30, 2017 17:21
@mention-bot
Copy link

@1ec5, thanks for your PR! By analyzing this pull request, we identified @boundsj, @incanus and @friedbunny to be potential reviewers.

@1ec5 1ec5 force-pushed the 1ec5-zh-hant-7370 branch from f29cb17 to 5eca251 Compare January 31, 2017 20:36
@1ec5 1ec5 force-pushed the 1ec5-zh-hant-7370 branch from 5eca251 to 8580f66 Compare February 1, 2017 22:00
@1ec5
Copy link
Contributor Author

1ec5 commented Feb 1, 2017

The Node macOS build failure is #7681.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 1, 2017

I’ve uploaded this translation to Transifex, where corrections are welcome. I’d prefer to merge this PR before #7923 so that this repository reflects the fact that zh-Hant is complete in Transifex.

Copy link
Contributor

@friedbunny friedbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from a Japanese-reader’s perspective. ;)

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 3, 2017

Merging as a prerequisite to #7923; if you spot any mistranslations, please correct them in Transifex.

@1ec5 1ec5 merged commit f76a49b into master Feb 3, 2017
@1ec5 1ec5 deleted the 1ec5-zh-hant-7370 branch February 3, 2017 06:48
"COPY_OSM" = "© OpenStreetMap";

/* Instructions in Interface Builder designable; {key}, {plist file name} */
"DESIGNABLE" = "在%2$@中將你的access token設爲%1$@可在這裏顯示Mapbox上的地圖\n\n更多說明請見";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!
The only thing I'm not sure about is 这裡 vs 这裏(L29 and L83). I know both are correct but it seems to me that 这裡 is more common in digital media?

cc @lily-chai @virginiayung ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can correct any issues you find inside Transifex. There's also a Comments tab you can use to flag mistranslations for others to review. We'll periodically pull translations in all languages from Transifex before release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Google Maps parity For feature parity with the Google Maps SDK for Android or iOS iOS Mapbox Maps SDK for iOS localization Human language support and internationalization macOS Mapbox Maps SDK for macOS MapKit parity For feature parity with MapKit on iOS or macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants