This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Add -fvisibility=hidden to iOS #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkaefer, thanks for your PR! By analyzing this pull request, we identified @1ec5, @friedbunny and @boundsj to be potential reviewers. |
1ec5
approved these changes
Jan 5, 2017
There was a problem hiding this comment.
Looks good. Make sure to check the static library to make sure an application can link to it. We should also make sure crash symbolication continues to work after this change, since that's been quite fragile lately.
/cc @friedbunny @boundsj
|
The build is failing where MGLStyleTests refers to some constants defined in mbgl-core: GIven #6301 (comment), we might need to rework these tests by hardcoding the version numbers in platform-specific code instead of centralizing them in mbgl. |
|
Alternatively, we could move all of those information to the header so that it doesn't need to be exported as symbols in the core library itself. |
kkaefer
force-pushed
the
7604-ios-sdk-symbol-visibility
branch
from
70760ac to
2b4e88b
Compare
kkaefer
force-pushed
the
7604-ios-sdk-symbol-visibility
branch
from
2b4e88b to
1ba3945
Compare
kkaefer
force-pushed
the
7604-ios-sdk-symbol-visibility
branch
from
1ba3945 to
e0f5755
Compare
|
Pushed an update to this |
|
Thanks @kkaefer, I’ll give this a try with the different iOS build flavors. |
friedbunny
force-pushed
the
7604-ios-sdk-symbol-visibility
branch
from
e0f5755 to
819824f
Compare
|
@kkaefer I’ve pushed up a rebase that includes the recently merged iOS v3.6.0 release branch. I also fixed an issue with the static build not having header search paths completely set (819824f). It looks like The static builds see no changes in binary size, so it appears that the After testing the dynamic and static builds in iOS apps, I’m reasonably confident this PR is 👍. Binary size metrics.ios-v3.6.0master @ b87816a7604-ios-sdk-symbol-visibility @ 819824f |
friedbunny
approved these changes
Jul 7, 2017
|
Looks great! Why do we need the polylabel headers specifically? |
|
@kkaefer The direct polylabel dependency was added by @fabian-guerra in #8713 for getting the pole of inaccessibility of a polygon annotation. If there’s a way to streamline/remove the polylabel header inclusion, that’d also be great. |
|
Proposed changing how polylabel is included in the iOS/macOS projects in #9469. |
friedbunny
force-pushed
the
7604-ios-sdk-symbol-visibility
branch
from
819824f to
808bca8
Compare
friedbunny
force-pushed
the
7604-ios-sdk-symbol-visibility
branch
from
808bca8 to
f426969
Compare
friedbunny
force-pushed
the
7604-ios-sdk-symbol-visibility
branch
from
f426969 to
73869d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #7509, but this time for iOS.