This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Merge {Glyph,Sprite}{Atlas,Store} #6358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
approved these changes
Sep 19, 2016
jfirebaugh
force-pushed
the
store-atlas-merge
branch
from
c1f2939 to
dc1861f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's probably a useful factoring of the functionality in
GlyphStoreandGlyphAtlas, andSpriteStoreandSpriteAtlas, but given that their main clientSymbolLayoutneeded access to all four, it's safe to say the existing factoring was not helpful. The fastest route to a more effective arrangement starts by merging them. I believe this is a prerequisite to #667. More immediately, mergingSpriteStoreandSpriteAtlasfixes #3817.