This repository was archived by the owner on Aug 8, 2023. It is now read-only.
port better symbol fading with texture lookups #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
force-pushed
the
better-symbol-fading
branch
2 times, most recently
from
3b13b9c to
fa8c4e4
Compare
|
@kkaefer I think you're more familiar with this part of the code. Can you review this? |
|
Getting the |
- this is simpler than predicting opacity based on current zooming speed - this is smoother: symbols don't flicker when changing zoom speed or when zooming in and out rapidly. mapbox/mapbox-gl-js@1df1466 fix #4562
jfirebaugh
force-pushed
the
better-symbol-fading
branch
from
fa8c4e4 to
9dff94c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when zooming in and out rapidly.
mapbox/mapbox-gl-js@1df1466
fix #4562
The second commit sets
glActiveTexturebefore binding any texture and makes sure that texture unit is correctly passed to the shader.👀 @jfirebaugh