This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Import required frameworks with static framework umbrella #4029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The umbrella header inside the static framework now imports the required iOS SDK frameworks so manual linking is unnecessary. This change corrects a regression introduced in #3183, when the umbrella header used in version 3.0.1 was removed.
Even these three are no longer needed, now that the umbrella header pulls them in.
1ec5
added a commit
that referenced
this pull request
Feb 22, 2016
…ions Backed out documentation about #4029 because it doesn’t apply when using a storyboard, and the installation instructions use a storyboard.
|
This change was partially backed out in 7bed2ce. If you start out with a storyboard and the static framework, you won’t be able to link the project until you import the module. To work around that, you need to link the various and sundry framework dependencies. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects a regression introduced in #3183, when the umbrella header used in version 3.0.1 was removed. The umbrella header inside the static framework now imports the required iOS SDK frameworks. With this change, it’s no longer necessary to manually link any frameworks other than Mapbox.framework.
/cc @friedbunny