Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Remove CoreTelephony dependency #2581

Merged
merged 1 commit into from
Oct 19, 2015
Merged

Remove CoreTelephony dependency #2581

merged 1 commit into from
Oct 19, 2015

Conversation

friedbunny
Copy link
Contributor

Removes the CoreTelephony framework dependency by conditionally using it if already linked.

If a developer chooses to link CoreTelephony in their app, telemetry data on their users' cellular carrier and connectivity will be collected.

Should also help the tvOS situation in #2340, which does not include CoreTelephony at the OS level.

/cc @incanus @1ec5 @twbell @camilleanne @mapbox/mobiledata

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS refactor telemetry Integration with Mapbox Telemetry libraries labels Oct 9, 2015
@friedbunny friedbunny added this to the ios-v2.2.0 milestone Oct 9, 2015
@1ec5
Copy link
Contributor

1ec5 commented Oct 9, 2015

If a developer chooses to link CoreTelephony in their app, telemetry data on their users' cellular carrier and connectivity will be collected.

Should we still call that out as an option in the installation instructions?

@friedbunny
Copy link
Contributor Author

Should we still call that out as an option in the installation instructions?

Figured we could do this mainly in the ios-sdk documentation, but I can add a note in INSTALL.md, too.

@friedbunny
Copy link
Contributor Author

Ehhhh, actually we don't mention metrics/telemetry anywhere in INSTALL.md. I'm inclined to go whole hog or leave it out entirely. Thoughts?

@bleege
Copy link
Contributor

bleege commented Oct 9, 2015

FYI... to make life easier in the future feel free to use the @mapbox/mobiledata team to keep all metrics / telemetry people in the loop.

@friedbunny
Copy link
Contributor Author

This is ready to go, pending me rebasing/squashing and Travis giving the green light. I'll hit documentation here with a brief note, as well as separately in ios-sdk.

@friedbunny
[ios] remove CoreTelephony dependency
28be82c 
Cellular carrier name and connectivity level will now only be sent if
the developer independently chooses to link the CoreTelephony framework
in their app.
@friedbunny friedbunny merged commit 28be82c into master Oct 19, 2015
@mourner mourner removed the ready label Oct 19, 2015
@friedbunny friedbunny deleted the can-you-hear-me-now branch October 19, 2015 18:47
@1ec5 1ec5 mentioned this pull request Oct 20, 2015
Closed
@friedbunny friedbunny mentioned this pull request Oct 21, 2015
Merged
@friedbunny friedbunny mentioned this pull request Dec 2, 2015
Merged
friedbunny added a commit that referenced this pull request Dec 3, 2015
@friedbunny
[ios] fix CoreTelephony crash (by removing it)
e5f136a 
Fix #3112, ref #2581
friedbunny added a commit that referenced this pull request Dec 3, 2015
@friedbunny @incanus
[ios] fix CoreTelephony crash (by removing it)
f67ceec 
Fix #3112, ref #2581
@1ec5 1ec5 added the tvOS Porting the Mapbox Maps SDK for iOS to tvOS label Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
iOS Mapbox Maps SDK for iOS refactor telemetry Integration with Mapbox Telemetry libraries tvOS Porting the Mapbox Maps SDK for iOS to tvOS
Projects
None yet
Milestone
ios-v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@friedbunny @1ec5 @bleege @mourner