This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Update minimum deployment versions to iOS 9, macOS 10.11 #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
iOS
julianrex
approved these changes
Apr 26, 2018
fabian-guerra
approved these changes
Apr 26, 2018
Lightweight generics are available everywhere with the bump to iOS 9 and macOS 10.11.
As long as we have a single database implementation that’s platform agnostic, I don’t think we’ll ever be able to switch to these methods. Though iOS will now support them, Android (per docs) didn’t get a suitable SQLite version until maybe API 21 (and even then manufacturers could supply different versions). Is this worth ticketing out? /cc @jfirebaugh @kkaefer |
|
Note that, from the time we merge this PR, any usage of lightweight generics with Foundation collections needs to be retrofitted with compatibility macros like |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #11663, this bumps the minimum deployment version of our SDKs to iOS 9 and macOS 10.11. These changes will take effect in
ios-v4.1.0andmacos-v0.8.0.To-do
Tail work
sqlite3_bind_blob64/sqlite3_bind_text64, now that our SQLite version supports them./cc @mapbox/maps-ios