This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Optimize MGLAnnotationView scale transform when not pitched #10951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
iOS
friedbunny
force-pushed
the
fb-unpitched-annotation-view-scaling
branch
from
5749158 to
2bb6bc0
Compare
|
Added a note to
|
1ec5
approved these changes
Jan 18, 2018
platform/ios/src/MGLAnnotationView.h
Outdated
| @@ -171,6 +171,10 @@ MGL_EXPORT | |||
|
|
|||
| The default value of this property is `YES`. Set this property to `NO` if the | |||
| view’s legibility is important. | |||
|
|
|||
| @note Scaling many on-screen view annotations can contribute to poor map | |||
There was a problem hiding this comment.
Nit: “view-backed annotations” or “annotation views”, but not “view annotations”. (All annotations go inside a view, the map view.)
friedbunny
force-pushed
the
fb-unpitched-annotation-view-scaling
branch
from
2bb6bc0 to
42845ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips 3D transform (pitch scaling) logic if an
MGLAnnotationViewwithscalesWithViewingDistance = YESis being shown on an unpitched map.This change yields a modest 5-10% reduction in the amount of time spent updating view annotation positions in such cases. Since
scalesWithViewingDistanceis enabled by default, this seems worthwhile.Moving around an unpitched map, post-optimization.
/cc @boundsj @1ec5