Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

consider dev update notification in IDE #7311

Closed
incanus opened this issue Dec 6, 2016 · 9 comments
Closed

consider dev update notification in IDE #7311

incanus opened this issue Dec 6, 2016 · 9 comments
Labels
documentation feature macOS Mapbox Maps SDK for macOS

Comments

@incanus
Copy link
Contributor

incanus commented Dec 6, 2016

Noticed something in the Realm Swift SDK the other day which I thought was pretty cool and could be useful for our mobile SDKs.

When you fire up your app (at least in Xcode) it lets you know if there is a new version available each and every launch:

2016-12-05 14:20:17.662 AppName[10934:484937] Version 2.1.1 of Realm is now available: https://github.com/realm/realm-cocoa/blob/v2.1.1/CHANGELOG.md

This is a nice feature and is both a notification as well as a subtle reminder to keep up to date. We could probably do it on Android, too (though IIRC the console is usually more verbose there and it might be missed).

@mapbox/ios @mapbox/android

@incanus incanus added Android Mapbox Maps SDK for Android documentation feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Dec 6, 2016
@1ec5
Copy link
Contributor

1ec5 commented Dec 6, 2016

Realm runs a version-checking Web service. Here’s the client-side code, which runs only in the Simulator.

@incanus
Copy link
Contributor Author

incanus commented Dec 6, 2016

runs only in the Simulator

Ooh, neat. 👍

@tobrun
Copy link
Member

tobrun commented Dec 6, 2016

That is pretty cool, for android we could hook into BuildConfig.DEBUG.

Side note: below is the most straightforward way of notifying users directly in the IDE:

screen shot 2016-12-06 at 18 45 08

It seems that this configuration isn't enabled by default for non-Google dependencies and requires the developer to enable this 😞.

@friedbunny
Copy link
Contributor

friedbunny commented Dec 8, 2016

I really like this idea, especially as Realm has implemented it (e.g., simulator-only). Google Maps iOS SDK prints a similar message when the view is first initialized, in addition to always printing the current version:

2016-12-07 22:36:23.259 treble[] Google Maps SDK for iOS version: 2.1.27410.0
2016-12-07 22:36:23.260 treble[] New version of Google Maps SDK for iOS available: 2.1.28321.0

@tobrun
Copy link
Member

tobrun commented Mar 3, 2017

Noticed today that Realm is showing an update notice in the gradle console:

screen shot 2017-03-03 at 10 18 09

Code for that is here.

@friedbunny
Copy link
Contributor

This happened for iOS in #8282.

@tobrun
Copy link
Member

tobrun commented Sep 19, 2018

Capturing from convo with @chloekraw and @LukasPaczos that default setup in #7311 (comment) is sufficient for Android. Removing label

@tobrun tobrun removed the Android Mapbox Maps SDK for Android label Sep 19, 2018
@friedbunny
Copy link
Contributor

friedbunny commented Sep 19, 2018

Cool, then I think we’re done here (unless @1ec5 has plans for this? feel free to reopen).

@1ec5
Copy link
Contributor

1ec5 commented Sep 24, 2018

unless @1ec5 has plans for this? feel free to reopen

It’s tracked on this project board for macOS, just so it doesn’t fall off my radar as a theoretical improvement. But I don’t see a practical need for it at this time, given that any macOS map SDK clients are likely to be using either CocoaPods or Carthage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation feature macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

4 participants