Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

clean up iOS versioning in scripts #3046

Closed
incanus opened this issue Nov 16, 2015 · 6 comments
Closed

clean up iOS versioning in scripts #3046

incanus opened this issue Nov 16, 2015 · 6 comments
Assignees
Labels
build iOS Mapbox Maps SDK for iOS refactor

Comments

@incanus
Copy link
Contributor

incanus commented Nov 16, 2015

Too many version determinations!

@incanus incanus added iOS Mapbox Maps SDK for iOS build refactor labels Nov 16, 2015
@incanus incanus self-assigned this Nov 16, 2015
@incanus incanus added this to the ios-v3.0.0 milestone Nov 16, 2015
@incanus
Copy link
Contributor Author

incanus commented Nov 16, 2015

This should also expose the option to tack on any -pre.X or -rc.Y designation, if desired.

@1ec5 1ec5 removed this from the ios-v3.0.0 milestone Nov 17, 2015
@1ec5
Copy link
Contributor

1ec5 commented Nov 17, 2015

Not critical for 3.0.0.

@incanus
Copy link
Contributor Author

incanus commented Nov 23, 2015

Also useful here is git tag --sort=-v:refname to combat the semantic versioning problem, but that still puts something like ios-v3.0.0-pre.10 ahead of ios-v3.0.0 final.

incanus added a commit that referenced this issue Nov 23, 2015
This is going to fail and output nothing for -pre and -rc tags for now
until #3046 is addressed. We can't yet grab those but still have final
releases sort after them.
@incanus
Copy link
Contributor Author

incanus commented Nov 23, 2015

We may want to grab something like node-semver as a packaging dependency rather than reinvent the wheel for version comparisons.

@incanus incanus added this to the ios-v3.1.0 milestone Nov 23, 2015
incanus added a commit that referenced this issue Dec 7, 2015
- Add license file to framework build step to satisfy CocoaPods linting.
- Log version when rolling framework (refs #3046).
- fixes #1426: get rid of dummy file since we make our own framework.
incanus added a commit that referenced this issue Dec 7, 2015
- Add license file to framework build step to satisfy CocoaPods linting.
- Log version when rolling framework (refs #3046).
- fixes #1426: get rid of dummy file since we make our own framework.
@1ec5
Copy link
Contributor

1ec5 commented Jan 6, 2016

Not critical for 3.1.0.

@1ec5 1ec5 removed this from the ios-v3.1.0 milestone Jan 6, 2016
@1ec5
Copy link
Contributor

1ec5 commented Apr 21, 2016

We still have a bunch of version-calculating code scattered about, but now it’s all based on git describe instead of fragile sorting. I think we’re good here.

@1ec5 1ec5 closed this as completed Apr 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS refactor
Projects
None yet
Development

No branches or pull requests

2 participants