Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Privatize emptyMemoryCache #1833

Closed
1ec5 opened this issue Jul 4, 2015 · 2 comments
Closed

Privatize emptyMemoryCache #1833

1ec5 opened this issue Jul 4, 2015 · 2 comments
Assignees
Labels
iOS Mapbox Maps SDK for iOS refactor
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jul 4, 2015

nitaliano/react-native-mapbox-gl#65 exposes -[MGLMapView emptyMemoryCache] to React Native users. Should this method even be public? I see that it’s used in iosapp’s gear menu, as a way of simulating low memory conditions. However, it doesn’t seem to have a good use case beyond that, and it’s poorly named to boot.

/cc @bsudekum @incanus

@incanus
Copy link
Contributor

incanus commented Jul 5, 2015 via email

@1ec5 1ec5 closed this as completed Jan 11, 2016
@1ec5 1ec5 reopened this Jan 11, 2016
@1ec5 1ec5 changed the title Should emptyMemoryCache be public? Privatize emptyMemoryCache Jan 11, 2016
@1ec5 1ec5 added this to the ios-v3.2.0 milestone Jan 29, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 29, 2016

Because this is public API, it needs to be deprecated before it can be removed. If it’s still useful in iosapp, then it should be redeclared via a category on MGLMapView and looked at askance.

@1ec5 1ec5 self-assigned this Apr 18, 2016
1ec5 added a commit that referenced this issue Apr 18, 2016
Deprecated -[MGLMapView emptyMemoryCache]. Switched ios-bench to a redeclared -didReceiveMemoryWarning as a workaround.

Fixes #1833.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS refactor
Projects
None yet
Development

No branches or pull requests

2 participants