queryRenderedFeatures: default params to empty object instead of throwing error #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapsam
changed the title
|
|
||
| map.queryRenderedFeatures(map.project(new LngLat(0, 0)), {foo: 'bar'}); | ||
| }); | ||
|
|
||
| t.end(); |
There was a problem hiding this comment.
The shared map across these test cases make me a little nervous but I don't see any immediate harm coming of it.
There was a problem hiding this comment.
Totally understood! I appreciate you sticking to convention. 😄 Let's leave these tests-as is for now.
| @@ -644,7 +644,7 @@ Style.prototype = util.inherit(Evented, { | |||
| } | |||
|
|
|||
| var includedSources = {}; | |||
| if (params.layers) { | |||
| if (params && params.layers) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Added a default empty object
{}tomap.queryRenderedFeatures()if nothing is passed through. Currently gl-js throws an error if the query is missing a second parameter. In order to pass linting tests, I had to renameparamstoparameterswithin the logic ofqueryRenderedFeatures.fixes #2969
Tests
Added two new tests that confirm the object is generated if it isn't passed through, and a test that confirms all parameters are preserved in the output (happy to remove this if it's unnecessary).
Refs
#2647
cc @lucaswoj @bhousel @mollymerp