Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix popup delay when moving the map #13412

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

ThugRaven
Copy link
Contributor

Fixes #12998 where popups visibly lag behind when moving the map (introduced in #12242).

Before (release-v2.11.0 and up):

before.mp4

After:

after.mp4

I've tested the fix for all issues addressed in #12242 to ensure they remain resolved. Additionally, I ran the unit tests, and all tests passed successfully.

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.

@ThugRaven ThugRaven requested a review from a team as a code owner February 20, 2025 20:40
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks, @ThugRaven

@stepankuzmin stepankuzmin merged commit df4901f into mapbox:main Feb 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup has delay (lags) compared to marker on mapMove and animations
3 participants