Document that trigonometric expressions use radians #13405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Style expressions like `["cos", arg]` take `arg` in radians, and their inverses return radians. This is a reasonable choice, but in context it may be a bit surprising, since latitudes and longitudes are typically expressed in degrees. Other expressions like `["pitch"]` also return degrees. This patch keeps the current behavior and describes it explicitly in the documentation. wchargin-branch: docs-trig-radians wchargin-source: a70bd704bb273703e4402cceec16a75742047706
|
|
underoot
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style expressions like
["cos", arg]takeargin radians, and their inverses return radians. This is a reasonable choice, but in context it may be a bit surprising, since latitudes and longitudes are typically expressed in degrees. Other expressions like["pitch"]also return degrees. This patch keeps the current behavior and describes it explicitly in the documentation.cc @mapbox/map-design-team
wchargin-branch: docs-trig-radians
Launch Checklist
Manually test the debug page.Write tests for all new functionality and make sure the CI checks pass.Post benchmark scores if the change could affect performance.@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.Tag@mapbox/gl-nativeif this PR includes shader changes or needs a native port.