Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't serialize SymbolFeature as part of SymbolInstance #7012

Closed
ChrisLoer opened this issue Jul 23, 2018 · 2 comments
Closed

Don't serialize SymbolFeature as part of SymbolInstance #7012

ChrisLoer opened this issue Jul 23, 2018 · 2 comments
Assignees
@ChrisLoer
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@ChrisLoer
Copy link
Contributor

When we transfer a symbol bucket from the workers to the foreground, we include a copy of the source feature for each SymbolInstance we generate:

mapbox-gl-js/src/data/bucket/symbol_bucket.js

Lines 76 to 77 in 83b147b

featureIndex: number,
feature: SymbolFeature,

These features are bulky and expensive to transfer, and as far as I know they're unused on the foreground. If we need access to the source feature on the foreground, we can use the "feature index" to look the feature up directly in the source data for the tile.

/cc @anandthakker @ansis @mourner
@ChrisLoer ChrisLoer added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Jul 23, 2018
@ChrisLoer ChrisLoer self-assigned this Jul 23, 2018
@ChrisLoer
Copy link
Contributor Author

This showed up as a significant part of the size of the JSON we transfer in: #7011.

ChrisLoer added a commit that referenced this issue Jul 23, 2018
@ChrisLoer
Stop unnecessary serialization of symbol source features.
d1da397 
Fixes issue #7012.
This data is expensive to serialize and isn't even being used.
@ChrisLoer ChrisLoer mentioned this issue Jul 23, 2018
Merged
6 tasks
mourner pushed a commit that referenced this issue Jul 23, 2018
@ChrisLoer @mourner
Stop unnecessary serialization of symbol source features. (#7013)
f2d8685 
Fixes issue #7012.
This data is expensive to serialize and isn't even being used.
@ChrisLoer
Copy link
Contributor Author

Fixed in #7013.

pirxpilot pushed a commit to pirxpilot/mapbox-gl-js that referenced this issue Sep 6, 2018
@ChrisLoer @pirxpilot
Stop unnecessary serialization of symbol source features. (mapbox#7013)
a51e356 
Fixes issue mapbox#7012.
This data is expensive to serialize and isn't even being used.
pirxpilot pushed a commit to pirxpilot/mapbox-gl-js that referenced this issue Sep 11, 2018
@ChrisLoer @pirxpilot
Stop unnecessary serialization of symbol source features. (mapbox#7013)
c80a503 
Fixes issue mapbox#7012.
This data is expensive to serialize and isn't even being used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisLoer ChrisLoer

Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisLoer