-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redoPlacement is broken for GeoJSON sources #3365
Comments
@jfirebaugh oof. At one point I'd thought to require each Source to expose a Given that the custom source API will undergo heavy development/revision (especially w/r/t workers), I'd propose tabling the general question for now. For the immediate-term fix, note that GeoJSONSources do expose |
Actually it looks like |
The 'redo placement' message does not include a
type
key, so when the worker receives the message, it defaults to'vector'
and callsredoPlacement
on the wrongWorkerSource
object.@lucaswoj @anandthakker Advice on fixing this?
Tile#redoPlacement
is passed aSourceCache
(the parameter name is misleading) and I don't immediately see a way to get the source type from that.The text was updated successfully, but these errors were encountered: