Fix for layer not found error in featuresAt function #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s exist before querying against them. updated existing test cases to account for this check and added a new test case to ensure missing layers are not included in the queryRenderedFeatures call.
|
Hi @caldwellc, Thanks for the contribution! Overall this looks good to me, just one minor nit. |
|
Any ideas when we can expect a 1.4.3 release @stepankuzmin? Thanks! |
Merged
|
Hi @lemmingapex. I just published v1.4.3 https://github.com/mapbox/mapbox-gl-draw/releases/tag/v1.4.3 |
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 17, 2024
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 18, 2024
…apbox#1194)"" This reverts commit 13e4243.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1183
Updated fetures_at.js's
featuresAtfunction to verify a style layer exists before adding it to queryParam.layers for the map.queryRenderedFeatures function. The mapbox-gl-draw style layers are removed during a map.setStyle call and are not added back until the data event (with type of style) is received. If the featuresAt function includes missing styles, the map.queryRenderedFeatures function will fire an error (https://github.com/mapbox/mapbox-gl-js/blob/11ea4f82e2d04041ef33339ac51909e876eed910/src/style/style.js#L1111C1-L1112C1)Updated test/utils/create_map.js mock of mapbox-gl-js's map to include a very basic style layer management.
Updated features_at.test.js to better mock the source/style handling of mapbox-gl-js so that a test case could be added to demonstrate this fix.