Use passive event listeners instead of preventDefault
#1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e error since Chrome 56 all touch event listeners are passive by default; https://chromestatus.com/feature/5093566007214080
…n chrome mobile error - preventDefault() skipped only for chrome browsers, drawing functions stopped working on other browsers
…g into main repo
|
Done. As mentioned, now my fork is not working as a dependency any longer.. 😅 Going to use a branch in my fork next time I supply a bugfix :-) |
stepankuzmin
changed the title
preventDefault
|
Excellent, thanks for the fix, @danielsippel! You can use this repo directly until we release a new version. |
This was referenced Jan 25, 2023
stepankuzmin
added a commit
that referenced
this pull request
Feb 14, 2023
… (h/t @danielsippel)" This reverts commit 84e35b7.
stepankuzmin
added a commit
that referenced
this pull request
Feb 14, 2023
… (h/t @danielsippel)" (#1158) This reverts commit 84e35b7.
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 17, 2024
…t` (mapbox#1146) (h/t @danielsippel)" (mapbox#1158)" This reverts commit 5a90472.
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 18, 2024
…ntDefault` (mapbox#1146) (h/t @danielsippel)" (mapbox#1158)"" This reverts commit 773abe7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1019
More information about the issue & solution: