This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Isochrone API refactor to use Java SDK wrapper #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osana , this pr is blocked by a bug in the Isochrone API code (my fault). I'm about to post an issue ticket in the Java SDK. |
This was referenced Apr 11, 2019
|
This pr is waiting on mapbox/mapbox-java#997 landing, a new version of the Java SDK being released, and then bumping this app's Java SDK dependency to the new number.... |
25 tasks
langsmith
force-pushed
the
ls-isochrone-refactor-to-use-Java-wrapper
branch
from
e8ab422 to
e68ae83
Compare
|
Ok, the refactoring on this pr gets
|
langsmith
force-pushed
the
ls-isochrone-refactor-to-use-Java-wrapper
branch
5 times, most recently
from
cfa1a6b to
1c83370
Compare
langsmith
force-pushed
the
ls-isochrone-refactor-to-use-Java-wrapper
branch
from
1c83370 to
438861d
Compare
|
Ok, this is ready for review |
osana
approved these changes
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr refactors
IsochroneActivityto use the Java SDK's Isochrone API support that landed in the4.6.0Java SDK release.