Ruff: add preview (DefectDojo#9759)

dojo/announcement/views.py

@@ -70,7 +70,7 @@ def configure_announcement(request):
 
 def dismiss_announcement(request):
     if request.method == "POST":
-        deleted_count, objects_deleted = UserAnnouncement.objects.filter(
+        deleted_count, _objects_deleted = UserAnnouncement.objects.filter(
             user=request.user, announcement=1
         ).delete()
         if deleted_count > 0:

dojo/api_v2/permissions.py

@@ -438,8 +438,8 @@ def has_permission(self, request, view):
             product_name,
             product_type_name,
             auto_create_context,
-            deduplication_on_engagement,
-            do_not_reactivate,
+            _deduplication_on_engagement,
+            _do_not_reactivate,
         ) = get_import_meta_data_from_dict(request.data)
         product_type = get_target_product_type_if_exists(product_type_name)
         product = get_target_product_if_exists(product_name, product_type_name)
@@ -645,8 +645,8 @@ def has_permission(self, request, view):
             product_name,
             product_type_name,
             auto_create_context,
-            deduplication_on_engagement,
-            do_not_reactivate,
+            _deduplication_on_engagement,
+            _do_not_reactivate,
         ) = get_import_meta_data_from_dict(request.data)
 
         product_type = get_target_product_type_if_exists(product_type_name)

dojo/api_v2/serializers.py

@@ -2238,7 +2238,7 @@ def save(self, push_to_jira=False):
             product_type_name,
             auto_create_context,
             deduplication_on_engagement,
-            do_not_reactivate,
+            _do_not_reactivate,
         ) = get_import_meta_data_from_dict(data)
         engagement = get_or_create_engagement(
             engagement_id,
@@ -2264,9 +2264,9 @@ def save(self, push_to_jira=False):
         try:
             (
                 test,
-                finding_count,
-                closed_finding_count,
-                test_import,
+                _finding_count,
+                _closed_finding_count,
+                _test_import,
             ) = importer.import_scan(
                 scan,
                 scan_type,
@@ -2557,11 +2557,11 @@ def save(self, push_to_jira=False):
                 reimporter = ReImporter()
                 (
                     test,
-                    finding_count,
-                    new_finding_count,
-                    closed_finding_count,
-                    reactivated_finding_count,
-                    untouched_finding_count,
+                    _finding_count,
+                    _new_finding_count,
+                    _closed_finding_count,
+                    _reactivated_finding_count,
+                    _untouched_finding_count,
                     test_import,
                 ) = reimporter.reimport_scan(
                     scan,
@@ -2608,8 +2608,8 @@ def save(self, push_to_jira=False):
                 importer = Importer()
                 (
                     test,
-                    finding_count,
-                    closed_finding_count,
+                    _finding_count,
+                    _closed_finding_count,
                     _,
                 ) = importer.import_scan(
                     scan,
@@ -2800,7 +2800,7 @@ def save(self):
                 try:
                     (
                         language_type,
-                        created,
+                        _created,
                     ) = Language_Type.objects.get_or_create(language=name)
                 except Language_Type.MultipleObjectsReturned:
                     language_type = Language_Type.objects.filter(

dojo/api_v2/views.py

@@ -2605,10 +2605,10 @@ def perform_create(self, serializer):
             engagement_id,
             engagement_name,
             product_name,
-            product_type_name,
-            auto_create_context,
-            deduplication_on_engagement,
-            do_not_reactivate,
+            _product_type_name,
+            _auto_create_context,
+            _deduplication_on_engagement,
+            _do_not_reactivate,
         ) = serializers.get_import_meta_data_from_dict(
             serializer.validated_data
         )
@@ -2784,10 +2784,10 @@ def perform_create(self, serializer):
             _,
             engagement_name,
             product_name,
-            product_type_name,
-            auto_create_context,
-            deduplication_on_engagement,
-            do_not_reactivate,
+            _product_type_name,
+            _auto_create_context,
+            _deduplication_on_engagement,
+            _do_not_reactivate,
         ) = serializers.get_import_meta_data_from_dict(
             serializer.validated_data
         )

dojo/endpoint/utils.py

@@ -291,7 +291,7 @@ def validate_endpoints_to_add(endpoints_to_add):
 def save_endpoints_to_add(endpoint_list, product):
     processed_endpoints = []
     for e in endpoint_list:
-        endpoint, created = endpoint_get_or_create(
+        endpoint, _created = endpoint_get_or_create(
             protocol=e[0],
             userinfo=e[1],
             host=e[2],
@@ -347,7 +347,7 @@ def endpoint_meta_import(file, product, create_endpoints, create_tags, create_me
                 if item[1] is not None and len(item[1]) > 0:
                     if create_meta:
                         # check if meta exists first. Don't want to make duplicate endpoints
-                        dojo_meta, create = DojoMeta.objects.get_or_create(
+                        dojo_meta, _create = DojoMeta.objects.get_or_create(
                             endpoint=endpoint,
                             name=item[0])
                         dojo_meta.value = item[1]

dojo/engagement/views.py

@@ -1227,7 +1227,7 @@ def download_risk_acceptance(request, eid, raid):
             open(settings.MEDIA_ROOT + "/" + risk_acceptance.path.name, mode='rb')))
     response['Content-Disposition'] = 'attachment; filename="%s"' \
                                       % risk_acceptance.filename()
-    mimetype, encoding = mimetypes.guess_type(risk_acceptance.path.name)
+    mimetype, _encoding = mimetypes.guess_type(risk_acceptance.path.name)
     response['Content-Type'] = mimetype
     return response
 

dojo/finding/helper.py

@@ -625,7 +625,7 @@ def add_endpoints(new_finding, form):
     new_finding.endpoints.set(form.cleaned_data['endpoints'] | Endpoint.objects.filter(id__in=endpoint_ids))
 
     for endpoint in new_finding.endpoints.all():
-        eps, created = Endpoint_Status.objects.get_or_create(
+        _eps, _created = Endpoint_Status.objects.get_or_create(
             finding=new_finding,
             endpoint=endpoint, defaults={'date': form.cleaned_data['date'] or timezone.now()})
 

dojo/finding/views.py

@@ -2277,7 +2277,7 @@ def apply_cwe_mitigation(apply_to_findings, template, update=True):
                         "CWE remediation text applied to finding for CWE: %s using template: %s."
                         % (template.cwe, template.title)
                     )
-                    new_note.author, created = User.objects.get_or_create(
+                    new_note.author, _created = User.objects.get_or_create(
                         username="System"
                     )
                     new_note.save()
@@ -2477,7 +2477,7 @@ class Original(ImageSpec):
         image = size_map[size](source=file).generate()
         response = StreamingHttpResponse(FileIterWrapper(image))
         response["Content-Disposition"] = "inline"
-        mimetype, encoding = mimetypes.guess_type(file_name)
+        mimetype, _encoding = mimetypes.guess_type(file_name)
         response["Content-Type"] = mimetype
         return response
 
@@ -3019,7 +3019,7 @@ def finding_bulk_update_all(request, pid=None):
                         (
                             can_be_pushed_to_jira,
                             error_message,
-                            error_code,
+                            _error_code,
                         ) = jira_helper.can_be_pushed_to_jira(group)
                         if not can_be_pushed_to_jira:
                             error_counts[error_message] += 1
@@ -3071,7 +3071,7 @@ def finding_bulk_update_all(request, pid=None):
                         (
                             can_be_pushed_to_jira,
                             error_message,
-                            error_code,
+                            _error_code,
                         ) = jira_helper.can_be_pushed_to_jira(finding)
                         if finding.has_jira_group_issue and not finding.has_jira_issue:
                             error_message = (

dojo/forms.py

@@ -1547,7 +1547,7 @@ def __init__(self, *args, **kwargs):
     def save(self):
         processed_endpoints = []
         for e in self.endpoints_to_process:
-            endpoint, created = endpoint_get_or_create(
+            endpoint, _created = endpoint_get_or_create(
                 protocol=e[0],
                 userinfo=e[1],
                 host=e[2],

dojo/importers/importer/importer.py

@@ -170,7 +170,7 @@ def process_parsed_findings(self, test, parsed_findings, scan_type, user, active
                 for unsaved_file in item.unsaved_files:
                     data = base64.b64decode(unsaved_file.get('data'))
                     title = unsaved_file.get('title', '<No title>')
-                    file_upload, file_upload_created = FileUpload.objects.get_or_create(
+                    file_upload, _file_upload_created = FileUpload.objects.get_or_create(
                         title=title,
                     )
                     file_upload.file.save(title, ContentFile(data))

dojo/importers/reimporter/reimporter.py

@@ -403,7 +403,7 @@ def process_parsed_findings(
                         title = unsaved_file.get("title", "<No title>")
                         (
                             file_upload,
-                            file_upload_created,
+                            _file_upload_created,
                         ) = FileUpload.objects.get_or_create(
                             title=title,
                         )

dojo/importers/utils.py

@@ -145,7 +145,7 @@ def add_endpoints_to_unsaved_finding(finding, test, endpoints, **kwargs):
                             "{}".format(e))
         ep = None
         try:
-            ep, created = endpoint_get_or_create(
+            ep, _created = endpoint_get_or_create(
                 protocol=endpoint.protocol,
                 userinfo=endpoint.userinfo,
                 host=endpoint.host,
@@ -158,7 +158,7 @@ def add_endpoints_to_unsaved_finding(finding, test, endpoints, **kwargs):
             raise Exception("Endpoints in your database are broken. Please access {} and migrate them to new format or "
                             "remove them.".format(reverse('endpoint_migrate')))
 
-        eps, created = Endpoint_Status.objects.get_or_create(
+        _eps, _created = Endpoint_Status.objects.get_or_create(
             finding=finding,
             endpoint=ep,
             defaults={'date': finding.date})

dojo/jira_link/helper.py

@@ -715,7 +715,7 @@ def failure_to_add_message(message: str, exception: Exception, object: Any) -> b
     jira_project = get_jira_project(obj)
     jira_instance = get_jira_instance(obj)
 
-    obj_can_be_pushed_to_jira, error_message, error_code = can_be_pushed_to_jira(obj)
+    obj_can_be_pushed_to_jira, error_message, _error_code = can_be_pushed_to_jira(obj)
     if not obj_can_be_pushed_to_jira:
         if isinstance(obj, Finding) and obj.duplicate and not obj.active:
             logger.warning("%s will not be pushed to JIRA as it's a duplicate finding", to_str_typed(obj))
@@ -1596,7 +1596,7 @@ def process_resolution_from_jira(finding, resolution_id, resolution_name, assign
                 finding.active = False
                 finding.mitigated = jira_now
                 finding.is_mitigated = True
-                finding.mitigated_by, created = User.objects.get_or_create(username='JIRA')
+                finding.mitigated_by, _created = User.objects.get_or_create(username='JIRA')
                 finding.endpoints.clear()
                 finding.false_p = False
                 ra_helper.risk_unaccept(finding)

dojo/notifications/views.py

@@ -90,7 +90,7 @@ def post(self, request: HttpRequest):
         # Set up the initial context
         context = self.get_initial_context(request, notifications, self.get_scope())
         # Determine the validity of the form
-        request, success = self.process_form(request, context)
+        request, _success = self.process_form(request, context)
         # Add any breadcrumbs
         request = self.set_breadcrumbs(request)
         # Render the page

dojo/okta.py

@@ -73,7 +73,7 @@ def validate_and_return_id_token(self, id_token, access_token):
         """
         Validates the id_token using Okta.
         """
-        client_id, client_secret = self.get_key_and_secret()
+        client_id, _client_secret = self.get_key_and_secret()
         claims = None
         k = None
 

dojo/pipeline.py

@@ -115,7 +115,7 @@ def assign_user_to_groups(user, group_names, social_provider):
         group, created_group = Dojo_Group.objects.get_or_create(name=group_name, social_provider=social_provider)
         if created_group:
             logger.debug("Group %s for social provider %s was created", str(group), social_provider)
-        group_member, is_member_created = Dojo_Group_Member.objects.get_or_create(group=group, user=user, defaults={
+        _group_member, is_member_created = Dojo_Group_Member.objects.get_or_create(group=group, user=user, defaults={
             'role': Role.objects.get(id=Roles.Maintainer)})
         if is_member_created:
             logger.debug("User %s become member of group %s (social provider: %s)", user, str(group), social_provider)
@@ -142,7 +142,7 @@ def update_product_access(backend, uid, user=None, social=None, *args, **kwargs)
         projects = gl.projects.list(membership=True, min_access_level=settings.GITLAB_PROJECT_MIN_ACCESS_LEVEL, all=True)
         project_names = [project.path_with_namespace for project in projects]
         # Create product_type if necessary
-        product_type, created = Product_Type.objects.get_or_create(name='Gitlab Import')
+        product_type, _created = Product_Type.objects.get_or_create(name='Gitlab Import')
         # For each project: create a new product or update product's authorized_users
         for project in projects:
             if project.path_with_namespace not in user_product_names:
@@ -153,7 +153,7 @@ def update_product_access(backend, uid, user=None, social=None, *args, **kwargs)
                     # If not, create a product with that name and the GitLab product type
                     product = Product(name=project.path_with_namespace, prod_type=product_type)
                     product.save()
-                product_member, created = Product_Member.objects.get_or_create(product=product, user=user, defaults={'role': Role.objects.get(id=Roles.Owner)})
+                _product_member, _created = Product_Member.objects.get_or_create(product=product, user=user, defaults={'role': Role.objects.get(id=Roles.Owner)})
                 # Import tags and/orl URL if necessary
                 if settings.GITLAB_PROJECT_IMPORT_TAGS:
                     if hasattr(project, 'topics'):

dojo/product/views.py

@@ -158,7 +158,7 @@ def view_product(request, pid):
     sla = SLA_Configuration.objects.filter(id=prod.sla_configuration_id).first()
     benchAndPercent = []
     for i in range(0, len(benchmarks)):
-        desired_level, total, total_pass, total_wait, total_fail, total_viewed = asvs_calc_level(benchmarks[i])
+        desired_level, total, total_pass, total_wait, total_fail, _total_viewed = asvs_calc_level(benchmarks[i])
 
         success_percent = round((float(total_pass) / float(total)) * 100, 2)
         waiting_percent = round((float(total_wait) / float(total)) * 100, 2)
@@ -1166,7 +1166,7 @@ def get_product(self, product_id: int):
         return get_object_or_404(Product, id=product_id)
 
     def get_test_type(self):
-        test_type, nil = Test_Type.objects.get_or_create(name=_("Pen Test"))
+        test_type, _nil = Test_Type.objects.get_or_create(name=_("Pen Test"))
         return test_type
 
     def get_engagement(self, product: Product):

dojo/reports/views.py

@@ -831,7 +831,7 @@ def add_extra_values(self):
         pass
 
     def get(self, request):
-        findings, obj = get_findings(request)
+        findings, _obj = get_findings(request)
         self.findings = findings
         findings = self.add_findings_data()
         response = HttpResponse(content_type='text/csv')
@@ -958,7 +958,7 @@ def add_extra_values(self):
         pass
 
     def get(self, request):
-        findings, obj = get_findings(request)
+        findings, _obj = get_findings(request)
         self.findings = findings
         findings = self.add_findings_data()
         workbook = Workbook()

dojo/templatetags/display_tags.py

@@ -220,7 +220,7 @@ def asvs_calc_level(benchmark_score):
 
 @register.filter
 def asvs_level(benchmark_score):
-    benchmark_score.desired_level, total, total_pass, total_wait, total_fail, total_viewed = asvs_calc_level(benchmark_score)
+    benchmark_score.desired_level, total, _total_pass, _total_wait, _total_fail, total_viewed = asvs_calc_level(benchmark_score)
 
     level = percentage(total_viewed, total)
 

dojo/test/views.py

@@ -860,7 +860,7 @@ def re_import_scan_results(request, tid):
             finding_count, new_finding_count, closed_finding_count, reactivated_finding_count, untouched_finding_count = 0, 0, 0, 0, 0
             reimporter = ReImporter()
             try:
-                test, finding_count, new_finding_count, closed_finding_count, reactivated_finding_count, untouched_finding_count, test_import = \
+                test, finding_count, new_finding_count, closed_finding_count, reactivated_finding_count, untouched_finding_count, _test_import = \
                     reimporter.reimport_scan(scan, scan_type, test, active=active, verified=verified,
                                                 tags=tags, minimum_severity=minimum_severity,
                                                 endpoints_to_add=endpoints_to_add, scan_date=scan_date,

dojo/tools/api_vulners/importer.py

@@ -12,12 +12,12 @@ class VulnersImporter(object):
     """
 
     def get_findings(self, test):
-        client, config = self.prepare_client(test)
+        client, _config = self.prepare_client(test)
         findings = client.get_findings()
         return findings
 
     def get_vulns_description(self, test, vulns_id):
-        client, config = self.prepare_client(test)
+        client, _config = self.prepare_client(test)
         description = client.get_vulns_description(vulns_id)
         return description
 

dojo/tools/checkmarx/parser.py

@@ -54,7 +54,7 @@ def _get_findings_xml(self, filename, test):
         #  - value: a list of vuln_id_from_tool
         vuln_ids_from_tool = dict()
         for query in root.findall("Query"):
-            name, cwe, categories, queryId = self.getQueryElements(query)
+            _name, _cwe, categories, _queryId = self.getQueryElements(query)
             language = ""
             findingdetail = ""
             group = ""
@@ -142,7 +142,7 @@ def _process_result_file_name_aggregated(
         Create the finding and add it into the dupes list
         If a vuln with the same file_path was found before, updates the description
         """
-        name, cwe, categories, queryId = self.getQueryElements(query)
+        _name, cwe, _categories, queryId = self.getQueryElements(query)
         titleStart = query.get("name").replace("_", " ")
         description, lastPathnode = self.get_description_file_name_aggregated(
             query, result

dojo/tools/kics/parser.py

@@ -44,7 +44,7 @@ def get_findings(self, filename, test):
                 expected_value = item.get("expected_value")
                 actual_value = item.get("actual_value")
 
-                description = f"{query.get('description','')}\n"
+                description = f"{query.get('description', '')}\n"
                 if platform:
                     description += f"**Platform:** {platform}\n"
                 if category: