fix #409: handle string input for num_results in google search and st… #524
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch and str replace editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Fix issue #409
#409
Feature Docs
Seems the issue cause by type mismatch when using Ollama on local service.
OpenAI and Claude API runs well with Google Search tool, only happens when using local Ollama service with llama 3.3 model (I only tried llama 3.3, not sure if other model also have the same issue).
Code Change
Influence
Only effect to Google Search tool only, I guess?
Result
Other
This is my first PR, please let me know if there is anything needs to be correct.