WIP Enhancement/7992967434/filters and projections ternary operator #2103

alexowens90 · 2025-01-07T09:34:14Z

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...

Have you updated the relevant docstrings, documentation and copyright notice?
Is this contribution tested against all ArcticDB's features?
Do all exceptions introduced raise appropriate error messages?
Are API changes highlighted in the PR description?
Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

…g pool

…ry operator

…operator

…ne value as operands

…ight operands

…add ternary operator to error message

alexowens90 added 12 commits December 9, 2024 16:28

Minimal Python API for testing

420113b

Most basic test passing

74ce8d2

Use numpy.where-like syntax

d07d0b0

Tidy up test, add todo

45ce82a

Simplifying refactor

e516465

Basic numeric projection with ternary operator working

ebf9cc4

Give projected columns their own segment so they can have a new strin…

f5706cf

…g pool

Ternary projections working with dynamic string columns

529baba

Fix dynamic schema projections with missing columns

1f8c0d7

Implement and test passing a bitset and a boolean column to the terna…

550a7a3

…ry operator

Implement and test passing a bitset and boolean value to the ternary …

252210c

…operator

Implement (untested) bitset with empty/full result args

124fc71

alexowens90 requested review from willdealtry and poodlewars as code owners January 7, 2025 09:34

alexowens90 marked this pull request as draft January 7, 2025 09:34

alexowens90 changed the title ~~Enhancement/7992967434/filters and projections ternary operator~~ WIP Enhancement/7992967434/filters and projections ternary operator Jan 7, 2025

alexowens90 self-assigned this Jan 7, 2025

alexowens90 added 13 commits January 8, 2025 09:35

Working with one empty/full result operand, and with one column and o…

c97928f

…ne value as operands

Implement and test bool columns with empty/full results as left and r…

04e34df

…ight operands

Handle two values as operands

73daff0

Values working with full and empty results

5eb3d94

Full and Empty results working with themselves

7cf527f

Working when condition is a FullResult or EmptyResult

012a02f

Remove unused parameters

151524f

Tidy up creating new segment in ProjectClause::process

f11e320

WIP tidying up operation_dispatch_ternary

2a9b11e

WIP more tidying up operation_dispatch_ternary

3488295

Improve error messages

50a0a08

Test ternary operator with lazy dataframes

5c23669

Made where a top-level import

8813ca2

alexowens90 added 10 commits January 9, 2025 17:11

Implement proper type promotion logic and test it

edc034c

Test invalid conditions, and improve error message

1e0692a

Test exceptions thrown when incompatible argument types provided

86621a2

Test exception thrown when trying to use pythonic ternary syntax and …

fa42b1f

…add ternary operator to error message

Test projections with column slicing, range, and multiindexes

c7972fa

Include Nones and NaNs in string column projection test

70e22e3

Throw sensible errors with fixed-width string columns

8047ff7

Remove unused functions

efe6269

Remove TODOs

319f45d

Projections with dynamic schema and missing columns tested

483d9fd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP Enhancement/7992967434/filters and projections ternary operator #2103

WIP Enhancement/7992967434/filters and projections ternary operator #2103

alexowens90 commented Jan 7, 2025

WIP Enhancement/7992967434/filters and projections ternary operator #2103

Are you sure you want to change the base?

WIP Enhancement/7992967434/filters and projections ternary operator #2103

Conversation

alexowens90 commented Jan 7, 2025

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist