-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for optional python_site_packages_path
in repodata
#3579
base: main
Are you sure you want to change the base?
Conversation
This is likely not a complete implementation for CEP-17 in mamba but may be enough to unblock This is rough and likely needs some work to finish things up but was hoping for initial feedback (or someone else to take over 😄). With these changes I was able to get the field to show up in the output of
|
Hi, thanks for tackling this! The implementation is neat and looks good to me, can you add some test to check this is correctly working? Also running |
python_site_packages_path
in repodata
Hi @jjhelmus, the support of CEP-17 is important for supporting Python 3.13t builds. Are you still interested in continuing this PR? |
I can still work on this but progress will be slow. If anyone wants to take over this work that would be fine. When I original started for on this, supported free-threading was a high priority for the team I was on. Since then, free-threading support is no longer a priority so I have very little time to work on this. |
Hi! I'm reviewing conda/conda-libmamba-solver#628 and in there we are already assuming that |
Add support for the optional python_site_packages_path field that can appear in repodata for python packages to specify the location of the site-packages directory. This optional field is defined in CEP-17.
Add the `python_site_packages_path` attribute to the PackageInfo class in the libmambapy bindings module.
Use the python_site_packages_path parameter from the python package in the environment as the site_package_path when available. When not specified fall back to setting this from the python version.
I found some time to work on this again and have been making some progress. Micromamba will now copy the contents of This can be checked using:
There should be a single directory, I'm still working on adding some tests, should have these complete by the end of the week. |
This PR is ready for review. With these changes, This field is exposed in There are tests at a unit and integration level. Happy to address any concerns. |
Add support for the optional
python_site_packages_path
field that can appear in repodata forpython
packages as a means to specify the location of the site-packages directory.This optional field is defined in CEP-17.
partial implementation for #3558
Please be kind as this is my first contribution to mamba and the first time digging into the source.