Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance Polls 2024-11-04 #2782

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Governance Polls 2024-11-04 #2782

merged 13 commits into from
Nov 4, 2024

Conversation

blimpa
Copy link
Collaborator

@blimpa blimpa commented Nov 3, 2024

@VoteWizard
fix table errors
913fd6d
@VoteWizard
Apply suggestions from code review
beb3941
@VoteWizard
Rename SparkLend Ethereum & Base - Activate Spark Liquidity Layer - N…
3e4359b 
…ovember 4, 2024.md to SparkLend Ethereum and Base - Activate Spark Liquidity Layer - November 4, 2024.md
0xldr
0xldr requested changes Nov 4, 2024
View reviewed changes
@VoteWizard @0xldr
Apply suggestions from code review
0a4196b 
Co-authored-by: 0xldr <139177554+0xldr@users.noreply.github.com>
MakerJanSky
MakerJanSky requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor items. Nice work, all.

MakerJanSky
MakerJanSky approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, all.

VoteWizard
VoteWizard approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@VoteWizard VoteWizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everyone! Great work!

@VoteWizard VoteWizard merged commit 5dd172e into makerdao:master Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xldr 0xldr 0xldr requested changes

@MakerJanSky MakerJanSky MakerJanSky approved these changes

@VoteWizard VoteWizard VoteWizard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blimpa @MakerJanSky @0xldr @VoteWizard