Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: refresh tls certs for test (#22792) #203

Merged

Conversation

oschaaf
Copy link
Contributor

@oschaaf oschaaf commented Sep 21, 2022

Cherry pick of c2fccb2 from upstream's main branch.

  • Removes TestSPIFFEValidator.TestDaysUntilFirstCertExpiresExpired as it didn't work on our branch. In a next release, we may want to re-add that.
  • Tweaked to change expectations to work with the code from our branch (strip .value())

Signed-off-by: wbpcode wangbaiping@corp.netease.com

Cherry pick of c2fccb2 from
upstream's main branch.

- Removes TestSPIFFEValidator.TestDaysUntilFirstCertExpiresExpired as it
didn't work on our branch. In a next release, we may want to re-add that.
- Tweaked change expectations to work with the code from our branch
  (strip .value())

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
@oschaaf oschaaf force-pushed the oschaaf-2.3-fix-cert-failures branch from ae3950d to e3d5b67 Compare September 21, 2022 15:59
@oschaaf
Copy link
Contributor Author

oschaaf commented Sep 21, 2022

(force push was to rebase this to the tip of maistra-2.3, forgot to sync my dev branch which was lagging when I branched out to work on this)

@maistra-bot maistra-bot merged commit c952df4 into maistra:maistra-2.3 Sep 21, 2022
@oschaaf oschaaf deleted the oschaaf-2.3-fix-cert-failures branch September 21, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants