Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSSM-553] Enable lua extension on ppc64le #113

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

yselkowitz
Copy link

Commit Message: Enable lua extension on ppc64le
Additional Description: Now that luajit2 is imported and enabled automatically on ppc, this is needed to actually build the http.lua extension.
Risk Level: Medium
Testing: Built on ppc64le (downstream)
Docs Changes: ??
Release Notes: ??
Platform Specific Features: Affects ppc64le only.

/cc @jwendell

@maistra-bot
Copy link

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwendell
Copy link
Member

jwendell commented Oct 1, 2021

/ok-to-test

@yselkowitz
Copy link
Author

/retest

@jwendell
Copy link
Member

jwendell commented Oct 4, 2021

LGTM.
@oschaaf ?

Copy link
Contributor

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change makes sense to me, just a question about the specifics on how we pull it off

@jwendell jwendell merged commit 59eaaba into maistra:maistra-2.1 Oct 4, 2021
@jwendell
Copy link
Member

jwendell commented Oct 4, 2021

merging manually due to time constraints, agreed with @oschaaf

@yselkowitz yselkowitz deleted the luajit-ppc64le branch October 5, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants