Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP 8.1, add Symfony 7 support #460

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Drop PHP 8.1, add Symfony 7 support #460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40c3428
Drop PHP 8.1 and update to Symfony 7
VincentLanglet Dec 3, 2023
8d8f1e6
Allow SF 6
VincentLanglet Dec 3, 2023
e5f89df
Update hash
VincentLanglet Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coding-standard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
dependencies:
- "locked"
php-version:
- "8.1"
- "8.2"
operating-system:
- "ubuntu-latest"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/infection.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
dependencies:
- "locked"
php-version:
- "8.1"
- "8.2"
- "8.3"
operating-system:
- "ubuntu-latest"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/phar-creation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: "shivammathur/setup-php@2.28.0"
with:
coverage: "none"
php-version: "8.1"
php-version: "8.2"
ini-values: memory_limit=-1, phar.readonly=0

- name: "Import GPG Key"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/phpstan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
dependencies:
- "locked"
php-version:
- "8.1"
- "8.2"
operating-system:
- "ubuntu-latest"

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/phpunit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
- "highest"
- "locked"
php-version:
- "8.1"
- "8.2"
- "8.3"
operating-system:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/psalm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
dependencies:
- "locked"
php-version:
- "8.1"
- "8.2"
operating-system:
- "ubuntu-latest"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/require-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
dependencies:
- "locked"
php-version:
- "8.1"
- "8.2"
operating-system:
- "ubuntu-latest"

Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
}
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.2.0 || ~8.3.0",
"ext-phar": "*",
"composer-runtime-api": "^2.0.0",
"nikic/php-parser": "^4.17.1",
"symfony/console": "^6.4.1",
"symfony/console": "^7.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to still allow symfony/console:^6 to allow others to upgrade? Otherwise we're punching them with a heavy multi-dependency bump 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I updated the PR

"webmozart/assert": "^1.11.0",
"webmozart/glob": "^4.6.0"
},
Expand All @@ -48,7 +48,7 @@
"optimize-autoloader": true,
"sort-packages": true,
"platform": {
"php": "8.1.99"
"php": "8.2.99"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this change is not valid: we're still supporting 8.1.x, so we should pin the composer update operations performed (by renovate and similar) to PHP 8.1, unless we drop support for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add some Ci to check we can install symfony 7 ?
Because I think symfony 7 require php 8.2.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also fine with dropping PHP 8.1 and calling it a day, tbh, but don't have a clean solution right now 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.1 is still used by around 37% of requests to packagist.org, 8.2 and up is only 33%. And the installation instructions state: Just download the latest PHAR and run it. Just sayin...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The percentage of existing users on 8.1 is totally irrelevant: we have old releases for that, which are very much valid.

Problem here is testing Symfony 7 while still enforcing a 8.2.99 platform: one possible way is --ignore-platform-req=php for CI pipelines targeting latest dependencies, but it introduces instability.

At that point, I'd say that dropping PHP 8.1 is the simplest way forward instead: I got shit to do, and making everyone happy won't get me paid anyway :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR and tried to drop PHP 8.1 then

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine here, thanks!

Please relax the symfony constraint though: we need at least one release allowing both major versions there

},
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true,
Expand Down
160 changes: 46 additions & 114 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.