-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New OAuth 2 ext package #710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethella
reviewed
Feb 15, 2024
One NIT, otherwise looks good to me. This could be a patch release, as it's the very first release |
romin-halltari
approved these changes
Feb 21, 2024
Ethella
approved these changes
Feb 21, 2024
bcleary06
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¦ Pull Request
This creates a new ext package oauth2. This will execute Magic's new oauth v2 flow with improved performance and stability.
β Fixed Issues
π¨ Test instructions
Please only add one label:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.π¦ Published PR as canary version:
Canary Versions
β¨ Test out this PR locally via:
npm install @magic-ext/oauth2@0.1.1-canary.710.7981256163.0 # or yarn add @magic-ext/oauth2@0.1.1-canary.710.7981256163.0