Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] tag list extension tutorial #3044

Merged
merged 6 commits into from
Mar 12, 2021

Conversation

jcalcaben
Copy link
Contributor

Description

Replaces the old tag list component tutorial with a tag list extension tutorial using more up to date patterns with Targets and Targetables.

Related Issue

Closes #3020

Closes PWA-1470

Acceptance

Any internal developer

Verification Stakeholders

Any internal developer

@larsroettig (optional)

Specification

Verification Steps

  1. Navigate to the pwa-devdocs directory: cd pwa-devdocs
  2. Run the HTML preview server: yarn develop
  3. Verify build succeeds and loads preview site
  4. Navigate to /tutorials/extension-development/taglist/
  5. Verify page loads and content is accurate
  6. Verify CodeSandbox iframe at the end of the topic loads successfully
  7. Verify topic is listed on the left navigation
  8. Verify Create a TagList component is NOT listed on the left navigation

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jcalcaben jcalcaben added pkg:pwa-devdocs documentation This pertains to documentation. version: Patch This changeset includes backwards compatible bug fixes. docs documentation labels Mar 4, 2021
@jcalcaben jcalcaben requested a review from larsroettig March 4, 2021 17:46
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 4, 2021

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 1c0f706

@supernova-at
Copy link
Contributor

Looks great! One minor change request but approved either way 👍

Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com>
@dpatil-magento dpatil-magento merged commit 60eb18f into develop Mar 12, 2021
@dpatil-magento dpatil-magento deleted the jimothy/pwa-1470_taglist-extension-tutorial branch March 12, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation documentation This pertains to documentation. pkg:pwa-devdocs Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback on page: /tutorials/create-taglist-component/
4 participants