-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create-pwa): Fix escaping in shell command create-pwa sends to buildpack #3022
fix(create-pwa): Fix escaping in shell command create-pwa sends to buildpack #3022
Conversation
…ildpack Fixes #2317. - Add escaping of space and quote characters in command path to buildpack - Fix Node > 14 bug in DEBUG_PROJECT_CREATION
|
Just to confirm the fix works on my end. Thanks @zetlen for tackling this. |
@zetlen Space part looks good. But when meant bin/sh: /Users/sdr/Documents/PWA/folder with space/packages/pwa-buildpack/bin/buildpack: No such file or directory |
@zetlen project create part with say There is small prettier fix you need to push though :) |
Created https://jira.corp.magento.com/browse/PWA-1527 to handle single/double quotation marks. This PR is good to merge after prettier fix. |
Description
Related Issue
Closes #2317.
Acceptance
Verification Stakeholders
@fooman
Specification
Verification Steps
Follow steps in #2317 by renaming your repo root folder something with spaces in it. Try both kinds of quotation marks as well!
Screenshots / Screen Captures (if appropriate)
Checklist