Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1003] Increase Test Coverage in venia-ui/lib/components/CreateAccountPage #3021

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

anthoula
Copy link
Contributor

Description

Increase test coverage for the CreateAccountPage component.

Related Issue

Closes #PWA-1003.

Acceptance

Any developer

Verification Stakeholders

Specification

Any developer

Verification Steps

  1. Run yarn test --collectCoverageFrom=**/createAccountPage.js packages/venia-ui/lib/components/CreateAccountPage/
  2. Verify tests succeed
  3. Verify acceptable test coverage

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@anthoula anthoula added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Feb 22, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 22, 2021

Messages
📖

Associated JIRA tickets: PWA-1003.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 9f06c7f

@anthoula anthoula marked this pull request as ready for review February 23, 2021 15:36
@dpatil-magento dpatil-magento merged commit c005187 into magento:develop Feb 23, 2021
@dpatil-magento dpatil-magento deleted the PWA-1003 branch February 23, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants