Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Venia UI App related tests #3015

Merged
merged 5 commits into from
Feb 24, 2021
Merged

Venia UI App related tests #3015

merged 5 commits into from
Feb 24, 2021

Conversation

revanth0212
Copy link
Contributor

Description

Added Venia UI App tests in an effort to increase the test coverage of PWA Studio project.

Related Issue

Closes PWA-1000

Verification Steps

Nothing should change from a functionality perspective. It is a test update.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@revanth0212 revanth0212 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Feb 17, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 17, 2021 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-1000.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 03e850f

tjwiebell
tjwiebell suggested changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@tjwiebell tjwiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for one more test and this looks ready. Nice work 👍

@dpatil-magento dpatil-magento merged commit 9c08247 into develop Feb 24, 2021
@dpatil-magento dpatil-magento deleted the revanth/venia_ui_app_tests branch February 24, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwiebell tjwiebell tjwiebell approved these changes

Assignees

@tjwiebell tjwiebell

Labels
pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@revanth0212 @PWAStudioBot @tjwiebell @dpatil-magento