Remove lodash from create-pwa #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
revanth0212
approved these changes
Feb 9, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
revanth0212
previously requested changes
Feb 9, 2021
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: approved
labels
supernova-at
previously approved these changes
Feb 9, 2021
jimbo
dismissed stale reviews from dpatil-magento and supernova-at
via
f007005
sirugh
reviewed
Feb 10, 2021
sirugh
previously approved these changes
Feb 10, 2021
revanth0212
previously approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Working when used against node packages/create-pwa/bin/create-pwa. Need to publish check against yarn create @magento/pwa. Thanks for working on this @jimbo.
|
Ignore the coveralls build, it triggered because of push event. @jimbo Please check on test failure though. |
sirugh
approved these changes
Feb 10, 2021
revanth0212
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
lodashfrom@magento/create-pwa.Related Issue
PWA-1452
Acceptance
Verification Stakeholders
Specification
Verification Steps
yarn createshould workScreenshots / Screen Captures (if appropriate)
Checklist