Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Extension development #2995

Merged
merged 6 commits into from
Feb 8, 2021
Merged

[doc] Extension development #2995

merged 6 commits into from
Feb 8, 2021

Conversation

jcalcaben
Copy link
Contributor

Description

Adds a new doc topic about extension development.

Related Issue

Closes PWA-797

Acceptance

Any developer

Verification Stakeholders

Any developer

Specification

Verification Steps

  1. Navigate to the pwa-devdocs directory
  2. Build the HTML preview server: yarn develop
  3. Verify site builds and accessible from browser
  4. Navigate to tutorials/extension-development/
  5. Verify topic exists and listed on the left navigation

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jcalcaben jcalcaben added pkg:pwa-devdocs documentation This pertains to documentation. version: Patch This changeset includes backwards compatible bug fixes. docs documentation labels Feb 5, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 5, 2021 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-797.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b0d8498

sirugh
sirugh requested changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change :)

@jcalcaben @sirugh
Update pwa-devdocs/src/tutorials/extension-development/index.md
f780e31 
Co-authored-by: Stephen <sirugh@users.noreply.github.com>
@jcalcaben jcalcaben requested a review from sirugh February 8, 2021 21:37
@dpatil-magento dpatil-magento merged commit a192637 into develop Feb 8, 2021
@dpatil-magento dpatil-magento deleted the jimothy/pwa-797_declaring-targets branch February 8, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirugh sirugh sirugh approved these changes

Assignees

@sirugh sirugh

Labels
docs documentation documentation This pertains to documentation. pkg:pwa-devdocs Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcalcaben @PWAStudioBot @sirugh @dpatil-magento