[FEATURE] Implement Checkmo #2927

[larsroettig]

Description

• ImplementsCheckmo

Related Issue

Closes PWA-1242.
Closes #2927

Acceptance

• Check/Money order is available during checkout if it's enabled for the website, available in the customer's country and the order total threshold is met. (Admin Panel Stores>configuration> Sales> Payment Methods> Check/Money Order)
• Check/Money order appears in the list of available payment methods according to the sorting order set in the Admin Configuration
• Billing address fields are shown for the check/money order payment if the Admin Panel configuration (Store>Configuration>Sales>Checkout> Checkout options> Display billing address on) set to Payment Method
• Make Check payable to and Send Check to values are store view specific and taken from Admin Panel Configuration. (Admin Panel Stores>configuration> Sales> Payment Methods> Check/Money Order)
• Payment method title _Pay by Check or Money order" is configurable in Admin Panel
• When Customer selects Check/Money order order, they complete checkout without providing any additional information related to payment method
• Customer sees payment information is displayed on order confirmation page and order history

Verification Steps

1. Checkout Branch
2. Config Checkmo in Magento backend
3. Link Extension in venia-concept package.json via

"dependencies": {
   "@magento/venia-sample-payments-checkmo": "link:../extensions/venia-sample-payments-checkmo"
},

4. run yarn install
5. run yarn watch:venia

Screenshots / Screen Captures (if appropriate)

Checklist

• I have added tests to cover my changes, if necessary.
• I have added translations for new strings, if necessary.
• I have updated the documentation accordingly, if necessary.

[PWAStudioBot]

	Fails
🚫	A version label is required. A maintainer must add one.

	Messages
📖	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against ce6c731

[revanth0212]

Nice work Lars. Ill look into the PR soon.

[revanth0212]

Wonderful work @larsroettig.

I love the fact that you have moved the Billing Address into a component of its own. I would suggest you make the changes to the existing payment methods that implement their own billing address to use this component. If you think that is gonna increase the scope of this PR, no problem let me know and Ill create a backlog ticket in our JIRA to take care of it.

Also, I have provided feedback. Most of them are general questions and some minor aesthetic changes.

Please make sure you add the tests once you have completed the work on the PR.

[fooman]

This is looking great to me. I like how you split out the BillingAddress as that will get lots of reuse. Overall I believe with this payment extension ready there will be one iteration left of the payment methods in general to have another look at how else we can make implementing payment methods easier.

This started with Luma but I really dislike how involved payment methods get with address handling and how each needs to implement their own order processing flow. Again apologies this is not the space for that discussion and this PR looks great 💯

[dpatil-magento]

@larsroettig With our current capabilities this >= would cause manual check for every package publishing in future. Can these dependencies be in sync with rest of the project with latest versions? something like -

    "@magento/peregrine": "~9.0.0",
    "@magento/pwa-buildpack": "~8.0.1",
    "@magento/venia-ui": "~6.0.1",

[larsroettig]

@dpatil-magento Sure i can do but this mean before publish you replace any version ?

[dpatil-magento]

@larsroettig Yes, we update dependencies to respective release latest versions. Example - When we go for next release and peregrine we identify as 10.0.0 then in above case "@magento/peregrine": "~9.0.0", will be replaced to "@magento/peregrine": "~10.0.0",

[larsroettig]

Good to know thanks pull commit the change now

[larsroettig]

07f0164 done ✔️

[dpatil-magento]

thanks @larsroettig

[dpatil-magento]

@larsroettig Data for Make Check Payable to and Send Check to is always static and not pulled from Admin configs. Please check this.

Another thing can be to haveEdit link once user has reviewed order but this is optional and should not block merging this PR.

[larsroettig]

@larsroettig Data for Make Check Payable to and Send Check to is always static and not pulled from Admin configs. Please check this.

Another thing can be to haveEdit link once user has reviewed order but this is optional and should not block merging this PR.

Hi @dpatil-magento, about Payable to and Send Check to is knowen because graphql coverage is not there for the backend.

Is accept at UX and productmangment

[dpatil-magento]

@larsroettig Thanks for the info, i was not knowing about graphql limitation. Will merge this soon :)