[PWA-1065] Media Url generation should use store code header but have fallback to default like other store config queries #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fallback to default like other store config queries - use storeConfig data on a store switch to get secure_base_media_url - save secure_base_media_url to storage - use secure_base_media_url in makeUrl, fallback to default
|
anthoula
added
the
version: Minor
…fallback to default like other store config queries - update snapshot
sirugh
reviewed
Jan 12, 2021
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
…fallback to default like other store config queries - set secure_base_media_url in storage, in the case of first load in non-default stores
…fallback to default like other store config queries - use global value from AVAILABLE_STORE_VIEWS for mediaBackend default
…fallback to default like other store config queries - fix existing tests
…fallback to default like other store config queries - add comment to specify where AVAILABLE_STORE_VIEWS is coming from
supernova-at
previously approved these changes
Jan 15, 2021
# Conflicts: # packages/peregrine/lib/talons/Header/__tests__/__snapshots__/useStoreSwitcher.spec.js.snap # packages/peregrine/lib/talons/Header/__tests__/useStoreSwitcher.spec.js # packages/peregrine/lib/talons/Header/storeSwitcher.gql.js # packages/peregrine/lib/talons/Header/useStoreSwitcher.js
…fallback to default like other store config queries - update test
…fallback to default like other store config queries - update mock data
|
QA Approved. |
supernova-at
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a admin user, I would like the ability to change settings in the admin panel to control the Media Url per store view so that I can store media assets for different locales in different media folders, and get that respected on Venia storefront.
Related Issue
https://jira.corp.magento.com/browse/PWA-1065
Acceptance
Verification Stakeholders
@dpatil-magento
@supernova-at
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist