Code

[feature]: ErrorView#2936

Code

Merged

dpatil-magento merged 20 commits intodevelopmagento/pwa-studio:developfrom rugh/pwa-1032-notFoundPagemagento/pwa-studio:rugh/pwa-1032-notFoundPageCopy head branch name to clipboardJan 14, 2021

+616-677

Commits

Commits on Jan 12, 2021

• Removing unused components.

  sirugh

  committed
  1923247

  Copy full SHA for 1923247

• Initial effort to refactor not found page

  Show description for 85778ac
  sirugh

  committed
  85778ac

  Copy full SHA for 85778ac

• Fix storybook global styles and fonts.

  Show description for 98155e8
  sirugh

  committed
  98155e8

  Copy full SHA for 98155e8

• Refactor ErrorView to generic component.

  sirugh

  committed
  f0a93e0

  Copy full SHA for f0a93e0

• Refactor Category Componet to use ErrorView

  sirugh

  committed
  e8b97c8

  Copy full SHA for e8b97c8

• Refactor CategoryList component to use ErrorView

  sirugh

  committed
  f1d09d0

  Copy full SHA for f1d09d0

• Refactor cmsBlock component to use ErrorView

  sirugh

  committed
  366e2bc

  Copy full SHA for 366e2bc

• Refactor Product component to use error view.

  sirugh

  committed
  4133450

  Copy full SHA for 4133450

• Remove code from props

  sirugh

  committed
  4749b1b

  Copy full SHA for 4749b1b

• Responsive background image and styling.

  Show description for 7559ac4
  sirugh

  committed
  7559ac4

  Copy full SHA for 7559ac4

• On error use default messaging but log in dev

  sirugh

  committed
  1b6c29f

  Copy full SHA for 1b6c29f

• Fix tests

  Show description for 1aa3287
  sirugh

  committed
  1aa3287

  Copy full SHA for 1aa3287

Commits on Jan 14, 2021

• Render error view as component instead of child

  sirugh

  committed
  9e00949

  Copy full SHA for 9e00949

• Only show loading indicator if loading and no data

  sirugh

  committed
  1916ee0

  Copy full SHA for 1916ee0

• Update imports to use package

  Show description for decf0da
  sirugh

  committed
  decf0da

  Copy full SHA for decf0da

• Update test

  Show description for 349924a
  sirugh

  committed
  349924a

  Copy full SHA for 349924a

• Move background image to component dir

  sirugh

  committed
  9843264

  Copy full SHA for 9843264

• Update snaps

  Show description for c787a44
  sirugh

  committed
  c787a44

  Copy full SHA for c787a44

• Add i18n defaults

  Show description for 0139ed0
  sirugh

  committed
  0139ed0

  Copy full SHA for 0139ed0

• snaps

  Show description for ff34cea
  sirugh

  committed
  ff34cea

  Copy full SHA for ff34cea