Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Basic desktop improvements for Venia - Mega Menu #2805

Closed
ericerway opened this issue Oct 21, 2020 · 22 comments · Fixed by #2932
Closed

[feature]: Basic desktop improvements for Venia - Mega Menu #2805

ericerway opened this issue Oct 21, 2020 · 22 comments · Fixed by #2932
Assignees
Labels
enhancement New feature or request help wanted Eligible for community contribution. Priority: P2 Progress: done Severity: S2

Comments

@ericerway
Copy link

ericerway commented Oct 21, 2020

No description provided.

@ericerway ericerway added enhancement New feature or request help wanted Eligible for community contribution. Priority: P2 Severity: S2 Event: mageconf MageConf 2020 labels Oct 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 21, 2020

Hi @ericerway. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@davemacaulay davemacaulay changed the title [feature]: Basic desktop improvements for Venia [feature]: Basic desktop improvements for Venia - Mega Menu Oct 22, 2020
@davemacaulay davemacaulay added hold On hold until another condition is fulfilled. and removed hold On hold until another condition is fulfilled. labels Oct 22, 2020
@ericerway
Copy link
Author

Minor updates to the design/spec added. 👍

@huykon
Copy link
Contributor

huykon commented Oct 24, 2020

@ericerway I have seen the Women category (highest level) have 5 sub-categories are: What's New, Bottom, Tops, Outerwear, Accessories. If that have more than 5 sub-categories, what the next sub-category will show on?

@schensley
Copy link

@huykon Great question! Ideally the area allowed for the menu items would be constructed in such a way that it would allow for that area to stretch to match the full-width of the header (here maxed at 1440px), this might allow for an additional column, BUT of course there may be merchants who have many sub-categories in which case there should be allowed to stack -- this would also be necessary when the screen size doesn't accommodate this optimal and orderly layout. In practical application the mega-menu will require some frontend design finesse to arrange columns and stacked sub-categories to provide a well organized and visually appealing layout.

@Frodigo
Copy link
Contributor

Frodigo commented Oct 31, 2020

@magento I am working on this

@Frodigo
Copy link
Contributor

Frodigo commented Nov 7, 2020

@ericerway I have one question. Take a look at the attached screenshot:

Screen Shot 2020-11-07 at 17 50 39

I suppose that "Women" is an active category name, but I don't understand from the 'Clothing' phrase came from.

@schensley
Copy link

Hi @Frodigo I think that is simply meant to be a reference label for reenforce which category was tapped in the navigation, and the designer might have taken some liberties adding "clothing" to give it greater separation in terms of hierarchy. I suppose it could serve as a breadcrumb which could be handy if this menu were to appear as an entire page where instead of "Clothing" it led with "Home" or something.

@ericerway ericerway removed the Event: mageconf MageConf 2020 label Nov 12, 2020
@sirugh
Copy link
Contributor

sirugh commented Nov 17, 2020

@schensley could we just say that for this iteration we dont include the breadcrumb/thing at the top as indicated? Just want to provide clear instructions for @Frodigo .

@Frodigo
Copy link
Contributor

Frodigo commented Dec 8, 2020

@schensley @sirugh I think that we can include this breadcrumb here. I can use the root category name as the first breadcrumb item and the hovered first-level category name as the second breadcrumb item.

Please confirm that it is OK for you.

Thanks,
Marcin

Frodigo added a commit to Frodigo/pwa-studio that referenced this issue Jan 9, 2021


 * added GraphQL query for Mega menu
 * added useMegaMenu talon
 * added MegaMenu component
 * added MegaMenuItem component
 * added Submenu component
 * added SubmenuColumn component
 * added MegaMenu to Header
 * added styles for Mega Menu
 * modified styles for header
@sirugh
Copy link
Contributor

sirugh commented Jan 19, 2021

@magento export issue to Jira project PWA as Story

@magento-engcom-team
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/PWA-1285) is successfully created for this issue.

@schensley
Copy link

@Frodigo I just had a look at the mega menu work you did and while it was designed pretty much to the UI design provided, I think there are some tweaks that should be made.

  • Let's discard the breadcrumb text. Initially I thought it might help provide better context, but it seems to add noise and maybe some confusion. We'll allow the underline in the Main Nav list to help the shopper know what category they are looking at.
  • Since in this instance there are not sub-categories in the list I suppose the categories (ex. Belts, Jewelry, Scarves) are acting as those headings, so let's have those be "semi-bold" or match the weight in the categories as they appear in the Main Nav list. If there were sub-categories beneath these cat. headings in the menu then they would assume a Regular weight.
  • Finally, let's ensure that items (group of columns) alignment is centered to the width of the Main Nav list. I realize with only two or three categories it can look a little "ragged", so maybe it already is aligned.

Attaching some visuals. Sorry for the tweaks, but after seeing the good work you've done I think some of the original direction was misguided. Thanks!

change
revised_specs
revised_clean

@Frodigo
Copy link
Contributor

Frodigo commented Jan 25, 2021

Hey, @schensley thanks for your feedback! I'll add changes soon.

@schensley
Copy link

@Frodigo thank you, sir.

Frodigo added a commit to Frodigo/pwa-studio that referenced this issue Feb 4, 2021


 * added GraphQL query for Mega menu
 * added useMegaMenu talon
 * added MegaMenu component
 * added MegaMenuItem component
 * added Submenu component
 * added SubmenuColumn component
 * added MegaMenu to Header
 * added styles for Mega Menu
 * modified styles for header
@Frodigo
Copy link
Contributor

Frodigo commented Feb 4, 2021

@schensley I added changes based on your comments and updated PR.

Screenshot 2021-02-04 at 07 47 47
Screenshot 2021-02-04 at 07 48 07

@schensley
Copy link

Thank you @Frodigo I think things are looking much cleaner.
The second sample you provided reveals something. The spacing between categories should be greater to more easily differentiate where one category title ends and the next one begins. Maybe increasing that minimum space to ~32px to 40px, room to span from the left edge of the logo to the right edge of the basket icon in the header, then wrap if it exceeds the space, again allowing enough padding between them that it's clear they are distinct. Thanks.

Frodigo added a commit to Frodigo/pwa-studio that referenced this issue Feb 22, 2021


 * added GraphQL query for Mega menu
 * added useMegaMenu talon
 * added MegaMenu component
 * added MegaMenuItem component
 * added Submenu component
 * added SubmenuColumn component
 * added MegaMenu to Header
 * added styles for Mega Menu
 * modified styles for header
@Frodigo
Copy link
Contributor

Frodigo commented Feb 22, 2021

Hey @schensley, I added final adjustments.
Screenshot 2021-02-22 at 19 55 52
Screenshot 2021-02-22 at 19 55 44

@schensley
Copy link

@Frodigo excellent. Thank you! UI/UX approved.

dpatil-magento added a commit that referenced this issue Mar 17, 2021
* [feature]: Basic desktop improvements for Venia - Mega Menu #2805
 * added GraphQL query for Mega menu
 * added useMegaMenu talon
 * added MegaMenu component
 * added MegaMenuItem component
 * added Submenu component
 * added SubmenuColumn component
 * added MegaMenu to Header
 * added styles for Mega Menu
 * modified styles for header

* Added improvements for MegaMenu

* Update prettier config (#2900)

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>

* #2981: let DEFAULT_TIMEOUT for Toasts be used (#2982)

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>

* - Version bumps (#2983)

- Remove comment causing deprecation warning
- Fix test that was mocking the filesystem causing upstream deps to fail

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>

* Visual adjustements for mega menu

* Mega menu - CR fixes

* Fixed mega menu initial state if cache data does not exist

* A few fixes -
unset active category on home/search
use callbacks vs inline functions
fixed some comments and prop ordering

Signed-off-by: sirugh <rugh@adobe.com>

* Handle null or empty url suffix

Signed-off-by: sirugh <rugh@adobe.com>

* forgot one

Signed-off-by: sirugh <rugh@adobe.com>

Co-authored-by: Piyush Dankhra <dankhrapiyush@gmail.com>
Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Co-authored-by: Brendan Falkowski <brendan@gravitydept.com>
Co-authored-by: Tommy Wiebell <twiebell@adobe.com>
Co-authored-by: sirugh <rugh@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Eligible for community contribution. Priority: P2 Progress: done Severity: S2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants