-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Basic desktop improvements for Venia - Mega Menu #2805
Comments
Hi @ericerway. Thank you for your report. Please, add a comment to assign the issue:
|
Minor updates to the design/spec added. 👍 |
@ericerway I have seen the Women category (highest level) have 5 sub-categories are: What's New, Bottom, Tops, Outerwear, Accessories. If that have more than 5 sub-categories, what the next sub-category will show on? |
@huykon Great question! Ideally the area allowed for the menu items would be constructed in such a way that it would allow for that area to stretch to match the full-width of the header (here maxed at 1440px), this might allow for an additional column, BUT of course there may be merchants who have many sub-categories in which case there should be allowed to stack -- this would also be necessary when the screen size doesn't accommodate this optimal and orderly layout. In practical application the mega-menu will require some frontend design finesse to arrange columns and stacked sub-categories to provide a well organized and visually appealing layout. |
@magento I am working on this |
@ericerway I have one question. Take a look at the attached screenshot: I suppose that "Women" is an active category name, but I don't understand from the 'Clothing' phrase came from. |
Hi @Frodigo I think that is simply meant to be a reference label for reenforce which category was tapped in the navigation, and the designer might have taken some liberties adding "clothing" to give it greater separation in terms of hierarchy. I suppose it could serve as a breadcrumb which could be handy if this menu were to appear as an entire page where instead of "Clothing" it led with "Home" or something. |
@schensley could we just say that for this iteration we dont include the breadcrumb/thing at the top as indicated? Just want to provide clear instructions for @Frodigo . |
@schensley @sirugh I think that we can include this breadcrumb here. I can use the root category name as the first breadcrumb item and the hovered first-level category name as the second breadcrumb item. Please confirm that it is OK for you. Thanks, |
@magento export issue to Jira project PWA as Story |
✅ Jira issue (https://jira.corp.magento.com/browse/PWA-1285) is successfully created for this issue. |
@Frodigo I just had a look at the mega menu work you did and while it was designed pretty much to the UI design provided, I think there are some tweaks that should be made.
Attaching some visuals. Sorry for the tweaks, but after seeing the good work you've done I think some of the original direction was misguided. Thanks! |
Hey, @schensley thanks for your feedback! I'll add changes soon. |
@Frodigo thank you, sir. |
@schensley I added changes based on your comments and updated PR. |
Thank you @Frodigo I think things are looking much cleaner. |
Hey @schensley, I added final adjustments. |
@Frodigo excellent. Thank you! UI/UX approved. |
* [feature]: Basic desktop improvements for Venia - Mega Menu #2805 * added GraphQL query for Mega menu * added useMegaMenu talon * added MegaMenu component * added MegaMenuItem component * added Submenu component * added SubmenuColumn component * added MegaMenu to Header * added styles for Mega Menu * modified styles for header * Added improvements for MegaMenu * Update prettier config (#2900) Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * #2981: let DEFAULT_TIMEOUT for Toasts be used (#2982) Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * - Version bumps (#2983) - Remove comment causing deprecation warning - Fix test that was mocking the filesystem causing upstream deps to fail Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> * Visual adjustements for mega menu * Mega menu - CR fixes * Fixed mega menu initial state if cache data does not exist * A few fixes - unset active category on home/search use callbacks vs inline functions fixed some comments and prop ordering Signed-off-by: sirugh <rugh@adobe.com> * Handle null or empty url suffix Signed-off-by: sirugh <rugh@adobe.com> * forgot one Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Piyush Dankhra <dankhrapiyush@gmail.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> Co-authored-by: Brendan Falkowski <brendan@gravitydept.com> Co-authored-by: Tommy Wiebell <twiebell@adobe.com> Co-authored-by: sirugh <rugh@adobe.com>
No description provided.
The text was updated successfully, but these errors were encountered: