[feature]: ErrorView (#2936)

* Removing unused components. * Initial effort to refactor not found page Signed-off-by: sirugh <rugh@adobe.com> * Fix storybook global styles and fonts. Global styles were applied accidentally in one of the stories. Fonts were never imported from the template. Now they match. * Refactor ErrorView to generic component. * Refactor Category Componet to use ErrorView * Refactor CategoryList component to use ErrorView * Refactor cmsBlock component to use ErrorView * Refactor Product component to use error view. * Remove code from props * Responsive background image and styling. Storybook functionality * On error use default messaging but log in dev * Fix tests Signed-off-by: sirugh <rugh@adobe.com> * Render error view as component instead of child * Only show loading indicator if loading and no data * Update imports to use package Signed-off-by: sirugh <rugh@adobe.com> * Update test Signed-off-by: sirugh <rugh@adobe.com> * Move background image to component dir * Update snaps Signed-off-by: sirugh <rugh@adobe.com> * Add i18n defaults Signed-off-by: sirugh <rugh@adobe.com> * snaps Signed-off-by: sirugh <rugh@adobe.com>
magento · Jan 14, 2021 · 6d32f84 · 6d32f84
1 parent e7d3f4f
commit 6d32f84
Show file tree

Hide file tree

Showing 39 changed files with 616 additions and 677 deletions.
diff --git a/packages/extensions/venia-sample-language-packs/i18n/fr_FR.json b/packages/extensions/venia-sample-language-packs/i18n/fr_FR.json
@@ -42,11 +42,9 @@
     "cartPage.signIn": "Se connecter",
     "cartPage.title": "Panier - {name}",
     "cartTrigger.ariaLabel": "Basculer le mini-panier. Vous avez {count} articles dans votre panier.",
-    "category.dataFetchError": "Erreur de récupération des données",
     "categoryContent.filter": "Filtre",
     "categoryContent.itemsSortedBy": "Articles triés par ",
     "categoryLeaf.allLabel": "Tout(e) {name}",
-    "categoryList.errorFetch": "Erreur de récupération des données: ",
     "categoryList.noResults": "Aucune catégorie enfant trouvée.",
     "checkoutPage.additionalText": "Vous recevrez également un courriel avec les détails et nous vous informerons lorsque votre commande aura été expédiée",
     "checkoutPage.accountSuccessfullyCreated": "Compte créé avec succès.",
@@ -94,7 +92,6 @@
     "checkoutPage.titleCheckout": "Paiement - {name}",
     "checkoutPage.titleReceipt": "Le reçu - {name}",
     "cms.shopByCategory": "Acheter par catégorie",
-    "cmsBlock.errorFetch": "Erreur de récupération des données",
     "cmsBlock.noBlocks": "Il n'y a aucun bloc à afficher",
     "communicationsPage.changesText": "Sauvegarder les modifications",
     "communicationsPage.communicationsText": "Les Communications",
@@ -258,7 +255,6 @@
     "priceSummary.lineItemLabel": "Sous-total",
     "priceSummary.total": "Total",
     "product.editItem": "Modifier l'article",
-    "product.errorFetch": "Erreur de récupération des données",
     "product.moveToFavorites": "Déplacer vers les favoris",
     "product.outOfStock": "En-rupture-de-stock",
     "product.outOfStockTryAgain": "Ce produit est actuellement en rupture de stock. Veuillez réessayer plus tard.",

diff --git a/packages/peregrine/lib/Page/__tests__/page.spec.js b/packages/peregrine/lib/Page/__tests__/page.spec.js
diff --git a/packages/peregrine/lib/Page/index.js b/packages/peregrine/lib/Page/index.js
diff --git a/packages/peregrine/lib/Page/page.js b/packages/peregrine/lib/Page/page.js
diff --git a/packages/peregrine/lib/Router/__mocks__/magentoRouteHandler.js b/packages/peregrine/lib/Router/__mocks__/magentoRouteHandler.js
diff --git a/packages/peregrine/lib/Router/__tests__/magentoRouteHandler.test.js b/packages/peregrine/lib/Router/__tests__/magentoRouteHandler.test.js
diff --git a/packages/peregrine/lib/Router/index.js b/packages/peregrine/lib/Router/index.js
@@ -1,4 +1,3 @@
-export { default as MagentoRouteHandler } from './magentoRouteHandler';
 export {
     default,
     Consumer as RouteConsumer,