Remove zend json from email #8707
Conversation
| /** | ||
| * @var \Magento\Framework\Serialize\Serializer\Json|\PHPUnit_Framework_MockObject_MockObject | ||
| */ | ||
| private $serilizerMock; |
There was a problem hiding this comment.
@dmanners could you please fix this type
|
@dmanners Thank you for the contribution! |
|
@okorshenko Why Closed and not Merged? |
|
@Ctucker9233 nice catch, there is typo in mainline currently due to not merged last commit of this PR: https://github.com/magento/magento2/blob/develop/app/code/Magento/Email/Test/Unit/Model/TemplateTest.php#L90 For PRs which did not become Merged automatically would be nice to have an automated check that all changes came to mainline (so that PR can be safely closed when we have all changes but some commit hashes are different). |
|
@orlangur Agreed. I just thought I'd ask because all previous comments and updates made it look like it was good to go and then it's suddenly closed with no explanation. |
|
@Ctucker9233 this PR is shown closed on GitHub but not merged, because the contributor did rebase of the branch and commit hashes changed. If we missed some commits from this PR, please, create additional PR to resolve the issue. Thank you |
|
@okorshenko in fact, not :) This was the case in another PR but not here. In https://github.com/magento/magento2/commits/develop/app/code/Magento/Email/Test/Unit/Model/TemplateTest.php we can see ce261ee has the same hash as in this PR.
This could sound as an overkill, simpler check could be - check if first commit from PR has the same hash in mainline. If not - rebase occured, if yes - need to check if all commits were added to mainline. Additional PR created. |
Since Zend Framework1 is EOF then we should start to move away from it.
This PR removes the usage of Zend_Json in the Email module.