[GRAPHQL] Made the attribute destination_cart_id for mergeCarts mutation not required.

[andrewbess]

Description (*)

This PR makes the attribute destination_cart_id for mergeCarts mutation not required.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [Atwix]Make the destination_cart_id argument optional in the mergeCarts mutation #30469: [Atwix] Make the destination_cart_id argument optional in the mergeCarts mutation

Manual testing scenarios (*)

Scenario 1.

1. Create an empty cart using GraphQl mutation createEmptyCart (keep the cart ID);
2. Add product to cart;
3. Generate customer token and write it to headers;
4. Merge guest cart (with ID kept above) with the current logged in customer's cart (don't use destination_cart_id)

mutation {
  mergeCarts(
    source_cart_id: "<YOUR-GUEST-CART-ID>"
  ) {
    items {
      id
      product {
        name
        sku
      }
      quantity
    }
  }
}

5. Check the response. The added product should be in the customer cart.

Scenario 2.

1. Generate customer token and write it to headers;
2. Get the cart ID using customerCart query;
3. Add the product(s) to cart;
4. Revoke customer token;
5. Create an empty cart using GraphQl mutation createEmptyCart (keep the cart ID);
6. Add product to cart;
7. Generate customer token and write it to headers (for the customer from p.1);
8. Merge guest cart (with ID kept in p.5) with the current logged in customer's cart (don't use destination_cart_id)

mutation {
  mergeCarts(
    source_cart_id: "<YOUR-GUEST-CART-ID>"
  ) {
    items {
      id
      product {
        name
        sku
      }
      quantity
    }
  }
}

9. Check the response. All added products should be in the customer cart.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[andrewbess]

@magento run all tests

[andrewbess]

@magento run all tests

[andrewbess]

@magento run all tests

[rogyar]

There's magic in 7.4 that allows us to turn it into

Suggested change

	$customerMaskedCartId = $customerMaskedCartId ?? $args['destination_cart_id'];
	$customerMaskedCartId ??= $args['destination_cart_id'];

But let's leave it as it is to preserve compatibility with 7.3

[rogyar]

Hi @andrewbess. Looks great, thanks. Please, check my suggestion regarding the test below

[rogyar]

I would ask you to cover this case with an additional test. The test will assert that without providing the destination cart id, the current cart is being used.

[andrewbess]

Hello @rogyar
Thank you for your review.
I extended the tests.
Please check.

Thank you in advance.

Pull Request state was updated. Re-review required.

[prabhuram93]

Hi @andrewbess can you check for null, for the new params here. We can have issues during the upgrade if not. Thanks!

[andrewbess]

Hello @prabhuram93
Thank you for your note.
I have fixed it.
Please check.
Thank you in advance.

[prabhuram93]

Looks good. Thanks!

[m2-assistant]

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.