Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Images in grid is not correctly aligned after clear filters #28366

Merged
merged 14 commits into from
Jul 16, 2020
Merged

Fix Images in grid is not correctly aligned after clear filters #28366

merged 14 commits into from
Jul 16, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented May 26, 2020 •
edited by lenaorobei
Loading

Description (*)

Fixed Issues (if relevant)

  1. Fixes Images in grid is not correctly aligned after clear filters adobe-stock-integration#824: Images in grid is not correctly aligned after clear filters
  2. Fixes Some images on the grid are not correctly aligned if open Preview in resized browser, and then maximize the web browser  adobe-stock-integration#972: Some images on the grid are not correctly aligned if open Preview in resized browser, and then maximize the web browser

Manual testing scenarios (*)

  • Login to admin panel
  • Navigate to Cms Pages
  • User clicks Add New Page button
  • Expand "Content" section
  • User clicks "Insert Image..." button
  • Click "Search Adobe Stock" button to open images grid
  • Select and apply filter Orientation=Square
  • Click Clear All

Expected result (*)

Images in grid is properly aligned

@m2-assistant
Copy link

m2-assistant bot commented May 26, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

This was referenced May 26, 2020
Closed
Closed
Closed
@Nazar65
Copy link
Member Author

Nazar65 commented May 26, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented May 26, 2020

@magento run Database Compare

@Nazar65
Copy link
Member Author

Nazar65 commented May 26, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented May 26, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented May 27, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented May 27, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented May 27, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented May 27, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented May 27, 2020

@magento run Static Tests

@Nazar65
Copy link
Member Author

Nazar65 commented May 28, 2020

@magento run all tests

@lenaorobei lenaorobei added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 22, 2020
@lenaorobei lenaorobei added this to the 2.4.1 milestone Jun 22, 2020
@ghost ghost assigned sivaschenko Jul 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7776 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Test on the cucumber studio - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4928288

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jul 2, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jul 2, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Golf engcom-Golf added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jul 3, 2020
This was referenced Jul 16, 2020
Closed
Closed
magento-engcom-team pushed a commit that referenced this pull request Jul 16, 2020
@lenaorobei
ENGCOM-7776: Fix Images in grid is not correctly aligned after clear …
31b25a7 
…filters #28366
@magento-engcom-team magento-engcom-team merged commit 90183a4 into magento:2.4-develop Jul 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@engcom-Charlie engcom-Charlie

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Ui Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
8 participants
@Nazar65 @magento-engcom-team @engcom-Bravo @engcom-Charlie @sivaschenko @lenaorobei @engcom-Golf @chalov-anton