Sku uniqueness

[dmanners]

This is a migration of the PR magento-engcom/import-export-improvements#119 from the now closed import-export-improvements repo.

Originally by @federivo and @pogster

Description

This PR may replace #102.
In contrast to the original PR I restored the SKU autogeneration in case a product is duplicated. The product copier will copy the original SKU and save the duplicate in a loop until a unique url key is found - if no SKU is autogenerated and no valid SKU is supplied it simply won't save the product.

Since the copier sets "isDuplicate" = true I thought it would be good simple solution to check for that entry before autogenerating a SKU.

Fixed Issues (if relevant)

magento-engcom/import-export-improvements#101

Manual testing scenarios

• Create product with sku "TEST"
• Create another product with sku "TEST"
• You should receive an error saying that the sku already exists instead of getting your sku modified.
• "Save & Duplicate" the product with sku "TEST"
• The duplicate receives the SKU "TEST-1" and will already be saved.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @dmanners. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[okorshenko]

@magento run all tests

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

As we discussed with @sidolov in slack - there were some issues, so I’ll move in from on hold to review it again

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, WebAPI Tests

[ihor-sviziev]

Hi @dmanners,
Sorry that we didn't processed your PR so much time!

I see that on this PR we have too many test failures it means that your changes breaks functionality. Could you do following?

1. review test failures and update your PR accordingly
2. Revert permissions changes on files you've changed
3. Sign Adobe CLA

Thank you so much for your contribution!

[ihor-sviziev]

@dmanners will you be able to update your PR based on feedback above?

[dmanners]

sure @ihor-sviziev either this week or next week I will get around to this.

[ihor-sviziev]

Hi @dmanners,
I see tests still failing after you pushed your last changes. Please check it again

[ihor-sviziev]

Hi @dmanners,
Will you be able to update your PR?

[dmanners]

Hi @ihor-sviziev sadly I have not been able to find the time to work on this.

[ihor-sviziev]

Hi @dmanners,
I am closing this PR now due to inactivity.
Please reopen and update your PR if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @dmanners, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.