Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix type error in Cart/Totals. #17620

Merged
merged 1 commit into from
Aug 19, 2018
Merged

[Forwardport] Fix type error in Cart/Totals. #17620

merged 1 commit into from
Aug 19, 2018

Conversation

nmalevanec
Copy link
Contributor

Description

Original pull request: magento-engcom/magento2ce#1186
Unset the address extension attributes before trying to create the quote totals.

Fixed Issues (if relevant)

  1. Type error in Cart/Totals #12993: Type error in Cart/Totals
  2. CartTotalRepository cannot handle extension attributes in quote addresses in 2.2.2 #12819: CartTotalRepository cannot handle extension attributes in quote addresses in 2.2.2

Manual testing scenarios

  1. Define extension attributes for the quote billing address
  2. Login as a user who has at least two addresses in his address book
  3. Add a virtual product to card and proceed to checkout
  4. Choose or change the billing address, click update, note no errors.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@fooman
Copy link
Contributor

fooman commented Aug 15, 2018

The original PR is unfortunately not public. I am however concerned that the proposed solution here essentially simply deletes data.

@fooman
Copy link
Contributor

fooman commented Aug 18, 2018

@antonkril a while ago we talked about issues around extension attributes. This is an example where I believe a better solution needs to be found.

The need to unset them, to me indicates, there is some gap with Extension Attributes in general which should be addressed on a higher level than fixing random occurrences of error messages with an unset.

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants